10:21 p.m.
Mike,
I've created a new pull request with the changes to deploy to repositories configured
in the settings.xml file. This is in https://github.com/droolsjbpm/guvnor/pull/112
I merged your changes in before making my edits so should be a simple merge.
The only question I have is for both you and Mario. There is some code overlap between
MavenRepository.java in kie-ci and GuvnorM2Repository.java. I ended up using some methods
almost exactly from MavenRepository in the GuvnorM2 class. The KIE methods I needed were
private so I didn't want to change them. The overall function of the two classes is
very similar. I think what is in place is fine but might be a future project to refactor
into one repository class for all of the kie enterprise.
Let me know when its merged and I'll switch to the new war.
Thanks for your help,
Joe
From: rules-dev-bounces(a)lists.jboss.org [mailto:rules-dev-bounces@lists.jboss.org] On
Behalf Of Joe White
Sent: Friday, March 21, 2014 2:18 PM
To: Rules Dev List
Subject: Re: [rules-dev] Pull request for remote deploy (GUVNOR-2088)
Makes sense. I'll follow the same pattern on the next one.
From: rules-dev-bounces@lists.jboss.org<mailto:rules-dev-bounces@lists.jboss.org>
[mailto:rules-dev-bounces@lists.jboss.org] On Behalf Of Michael Anstis
Sent: Friday, March 21, 2014 2:09 PM
To: Rules Dev List
Subject: Re: [rules-dev] Pull request for remote deploy (GUVNOR-2088)
Hi Joe,
I merged it to master
here<https://github.com/droolsjbpm/guvnor/commit/e6121cdb6e126fd57dbaa...;.
There was potential for a NPE if a <distributionManagement> section was not defined
in the POM.
I also split deployment to the "default workbench" remote repository and any
additional remote into two try {...} catch blocks; so that if one fails the other still
gets a chance to execute.
Cheers,
Mike
On 21 March 2014 20:02, Michael Anstis
<michael.anstis@gmail.com<mailto:michael.anstis@gmail.com>> wrote:
Hi Joe,
I'm just merging your PR - and tweaking a couple of bits - there was potential for a
NPE and some tests were failing.
Please submit as a new PR.
Thanks,
Mike
On 21 March 2014 19:58, Joe White
<Joe.White@recondotech.com<mailto:Joe.White@recondotech.com>> wrote:
Thanks Mike.
I will update to deploy to default profile repositories as well and add that to the pull
request.
Joe
From: rules-dev-bounces@lists.jboss.org<mailto:rules-dev-bounces@lists.jboss.org>
[mailto:rules-dev-bounces@lists.jboss.org<mailto:rules-dev-bounces@lists.jboss.org>]
On Behalf Of Michael Anstis
Sent: Friday, March 21, 2014 1:48 PM
To: Rules Dev List
Subject: Re: [rules-dev] Pull request for remote deploy (GUVNOR-2088)
Great stuff Joe!
We like to promote that KIE operates "like normal" with regards to Maven. If
you've noticed another short fall it'd be great for if you could plug that gap too
I'll merge the lot next week.
Other aspects of KIE honour Maven conventions (such as default profiles) and the workbench
in this regard should be no different.
Thanks,
Mike
Sent on the move
On 21 Mar 2014 19:31, "Joe White"
<Joe.White@recondotech.com<mailto:Joe.White@recondotech.com>> wrote:
I have created a pull request that updates the GuvnorM2Repository code to deploy to a
remote repository if one is configured in the <distributionManagement> section of a
pom in the workbench. If the repository requires authentication the system will fetch the
credentials by repository id from the settings.xml file.
I tested this publishing to both a snapshot and a release repository. Both require
credentials and both worked (thanks to mfusco).
One question:
Currently it does not publish to the default profile repositories in the settings.xml.
Should it? In other words, if the user has a default profile in their settings should
Guvnor go ahead and deploy to the configured repository? This would fit with normal maven
operation but I don't know if the user would expect the workbench code to be handled
differently.
If you guys want Guvnor to publish to the settings.xml repositories automatically let me
know and I can make that update as well.
Once the above is decided I'll update the documentation and create a pull request for
that as well.
https://github.com/droolsjbpm/guvnor/pull/111
Joe
_______________________________________________
rules-dev mailing list
rules-dev@lists.jboss.org<mailto:rules-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-dev
_______________________________________________
rules-dev mailing list
rules-dev@lists.jboss.org<mailto:rules-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-dev