12:18 a.m.
In the KieRepositoryImpl code what is the purpose of instantiating to the DummyScanner if
the kie-ci jar is not on the classpath. Lines 120-126 in the impl. Ultimately this results
in a Not Found exception downstream but masks the true issue of the missing jar. Seems
like it would be better off throwing the exception back out to the caller so they know
they are missing the jar?
I'm just trying to get a handle on how it is all wired together and spent a couple of
hours chasing why it wouldn't find my kmodule jar when the core problem was my ear was
just missing the kie-ci.
Thanks,
Joe
3:53 a.m.
I suspect the DummyKieScanner was there to avoid people getting null pointers. But I think
actually it may be best to throw an exception, to fail fast. The dummy can’t be used for
anything, and it will jut confuse users.
@mario: thoughts?
Mark
On 7 Mar 2014, at 23:18, Joe White <Joe.White(a)recondotech.com> wrote:
In the KieRepositoryImpl code what is the purpose of instantiating to
the DummyScanner if the kie-ci jar is not on the classpath. Lines 120-126 in the impl.
Ultimately this results in a Not Found exception downstream but masks the true issue of
the missing jar. Seems like it would be better off throwing the exception back out to the
caller so they know they are missing the jar?
I’m just trying to get a handle on how it is all wired together and spent a couple of
hours chasing why it wouldn’t find my kmodule jar when the core problem was my ear was
just missing the kie-ci.
Thanks,
Joe
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
9:04 a.m.
Joe,
as said by Mark the DummyKieScanner acts only as a placeholder to avoid
tons of null checks inside the code. But you're right when you wrote that
it should fail fast when requested to load an artifact. I'll make the
DummyKieScanner.loadArtifact methods to throw a more meaningful Exception
when invoked.
Thank you for having reported this,
Mario
On Sat, Mar 8, 2014 at 3:53 AM, Mark Proctor <mproctor(a)codehaus.org> wrote:
I suspect the DummyKieScanner was there to avoid people getting null
pointers. But I think actually it may be best to throw an exception, to
fail fast. The dummy can’t be used for anything, and it will jut confuse
users.
@mario: thoughts?
Mark
On 7 Mar 2014, at 23:18, Joe White <Joe.White(a)recondotech.com> wrote:
In the KieRepositoryImpl code what is the purpose of instantiating to the
DummyScanner if the kie-ci jar is not on the classpath. Lines 120-126 in
the impl. Ultimately this results in a Not Found exception downstream but
masks the true issue of the missing jar. Seems like it would be better off
throwing the exception back out to the caller so they know they are missing
the jar?
I’m just trying to get a handle on how it is all wired together and spent
a couple of hours chasing why it wouldn’t find my kmodule jar when the core
problem was my ear was just missing the kie-ci.
Thanks,
Joe
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
3952
days inactive
3955
days old
2 comments
3 participants
participants (3)
-
Joe White -
Mario Fusco -
Mark Proctor