Re: [seam-dev] Feedback - JMS APIs

On 06/02/2011 03:29 AM, John D. Ament wrote: I think that it's still a good idea to separate the routing rules from the event firing / observing. The need for extra code could be addressed by further simplification of annotation configuration e.g: @Route(type=EGRESS, payloadType=String.class, qualifiers={}, destinationJndiName="jms/MyTopic", destinationType=Topic.class) or @Route(type=INGRESS, payloadType=Long.class, qualifiers={}, destinationJndiName="jms/MyQueue", destinationType=Queue.class) In the second example, attribute names may be a bit confusing (the Queue is actually a source, not a destination) thus using a separate annotation for each routing type may be a better approach @EgressRoute(payloadType=String.class, qualifiers={}, destinationJndiName="jms/MyTopic", destinationType=Topic.class) @IngressRoute(payloadType=Long.class, qualifiers={}, sourceJndiName="jms/MyQueue", sourceType=Queue.class) Each of these annotations would represent a single routing rule. These rules could be expressed like: @Routes({ @EgressRoute(...), @EgressRoute(...), @IngressRoute(...) }) This IMHO makes it easier to define routing rules compared to the interface approach[1] [1] http://docs.jboss.org/seam/3/jms/3.0.0.Beta2/reference/en-US/html/mapping...