Re: [jboss-dev] New Break the Build Policy - testsuite - discussion
On Wed, 2008-10-01 at 16:32 +0100, Kabir Khan wrote:
> On 10/01/2008 05:05 AM, Adrian Brock wrote:
>> A branch will be created for the broken build
>> before rolling back so the commit(s) can be fixed
>> and tested before re-merging.
>
> I vote against this, if my vote counts.
What does voting have to do with it?
You either have a persuasive, reasoned argument or you don't.
"I don't like it" isn't an argument. :-)
Just roll it back, you
> don't need a branch.
The purpose of the branch is so that
the person that broke the build can get help when they
don't understand why it broke.
Or when concurrent commits conflicted with each other.
It's really upto the person that needs help with the commit
whether they branch from the rolled back revision
or create a branch from the most recent revision and
re-apply their patch.
The important part is that don't just keep recommitting it
to trunk or a stable branch
which potentially stops everybody else from working.
The original committer can use "svn merge -
> rXX:YY" to re-merge the change in their local tree. We already have
> an awful lot of branches as is.
You can't get somebody else to look at the problem if it only
exists in your local tree.
Or alternatively create the branch somewhere else than under the
branches/ folder, e.g.
https://svn.jboss.org/repos/jbossas/brokenbuilds/whatever
Sounds reasonable. Although I think we can come up with
a funnier name than "brokenbuilds"? :-)
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx