Re: [jboss-dev] Enforcing JDK6 in AS trunk
Ian Springer wrote:
Building AS trunk w/ JDK7 also fails for me
(http://wwwapps.rdu.redhat.com/w3xpastebin/pastebin.php?show=13872).
This one is
because of the way the profile activation configuration in
connector/pom.xml
http://anonsvn.jboss.org/repos/jbossas/trunk/connector/pom.xml:
<profiles>
<profile>
<id>jdk6</id>
<activation>
<jdk>1.6</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.6</source>
<target>1.6</target>
<excludes>
<exclude>org/jboss/resource/adapter/jdbc/jdk5/**</exclude>
</excludes>
This profile is activated only with JDK-6 because of the configuration. I tried changing
it to :
<activation>
<jdk>[1.6,)</jdk>
</activation>
to activate it even with JDK-7 but for some reason Maven doesn't activate this
profile. I'll discuss with Paul Gier to see what can be done.
regards,
-Jaikiran
If this is expected, we should also disallow JDK7, e.g.:
<requireJavaVersion>
<version>[1.5,1.7)</version> <!-- 1.5.x, 1.6.x -->
</requireJavaVersion>
On 9/9/2009 11:43 AM, Jaikiran Pai wrote:
> Stan Silvert wrote:
>
>> Is it possible to require a certain revision (or higher) of 1.6? I
>> can remember that the build wouldn't work with some older revisions of
>> 1.6.
>>
>> Stan
>>
> That should be possible
> http://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html
>
>
> -Jaikiran
>
>
>> Jaikiran Pai wrote:
>>
>>> Resending, since the previous mail never made it to the list.
>>>
>>> -Jaikiran
>>>
>>> Jaikiran Pai wrote:
>>>
>>>
>>>> Hello everyone,
>>>>
>>>> Half way while building a clean AS trunk today, the build failed with
>>>> incompatible class versions. With the recent changes to AS trunk,
>>>> JDK6
>>>> is now mandatory for the build to complete successfully. If no one
>>>> has
>>>> any objections, i'll update the parent pom.xml in AS trunk to
enforce
>>>> this through the enforcer plugin:
>>>>
>>>>
>>>> Index: pom.xml
>>>> ===================================================================
>>>> --- pom.xml (revision 93223)
>>>> +++ pom.xml (working copy)
>>>> @@ -609,7 +609,7 @@
>>>> <version>2.0.9</version>
>>>> </requireMavenVersion>
>>>> <requireJavaVersion>
>>>> -<version>1.5</version>
>>>> +<version>1.6</version>
>>>> </requireJavaVersion>
>>>> </rules>
>>>> </configuration>
>>>>
>>>>
>>>> regards,
>>>> -Jaikiran
>>>>
>>>>
>>>>
>>> _______________________________________________
>>> jboss-development mailing list
>>> jboss-development(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>>
>>>
>>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>