7:25 a.m.
I'm getting weird trace log lines:
2007-08-16 14:13:00,258 TRACE [org.jboss.deployment.EARStructure:70] Not recognised:
ejb3_bb_stateless_enventry_ejb.jar
There is no Logger defined in EARStructure and thus nothing interesting
on line 70.
But AbstractStructureDeployer defines this:
protected Logger log = Logger.getLogger(getClass());
But still nothing interesting on line 70.
1. Shouldn't AbstractStructureDeployer use
Logger.getLogger(AbstractStructureLogger.class)?
2. What the hell is going on?
Carlo
7:51 a.m.
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontaine...
On Thu, 2007-08-16 at 14:25 +0200, Carlo de Wolf wrote:
I'm getting weird trace log lines:
2007-08-16 14:13:00,258 TRACE [org.jboss.deployment.EARStructure:70] Not recognised:
ejb3_bb_stateless_enventry_ejb.jar
There is no Logger defined in EARStructure and thus nothing interesting
on line 70.
But AbstractStructureDeployer defines this:
protected Logger log = Logger.getLogger(getClass());
But still nothing interesting on line 70.
1. Shouldn't AbstractStructureDeployer use
Logger.getLogger(AbstractStructureLogger.class)?
2. What the hell is going on?
Carlo
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
9:12 a.m.
On Thu, 16 Aug 2007 14:51:44 +0200
Adrian <abrock(a)redhat.com> wrote:
41 : private Logger log;
Bleah - loggers really ought to be static. Creating a zillion loggers caused
significant performance problems in vfs one time already.
If you *really* want the logger to map to the instantiating class, just make
the logger field protected, and have the subclass constructor assign their
(static) logger to the protected field. Or something.
- DML
10:22 a.m.
On Thu, 2007-08-16 at 09:12 -0500, David M. Lloyd wrote:
On Thu, 16 Aug 2007 14:51:44 +0200
Adrian <abrock(a)redhat.com> wrote:
>
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontaine...
> 41 : private Logger log;
Bleah - loggers really ought to be static. Creating a zillion loggers caused
significant performance problems in vfs one time already.
There are only 5 structure deployers and each is a singleton.
You're correct that it is wrong to have a non-static logger
for things that are not singletons.
I remember when org.jboss.tm.TransactionImpl had a non-static
logger, because I fixed it. ;-)
If you *really* want the logger to map to the instantiating class,
just make
the logger field protected, and have the subclass constructor assign their
(static) logger to the protected field. Or something.
It's the same number of loggers and your solution is both
more complicated and introduces an implementation/debug detail into
an integration api where it does NOT belong.
i.e. A StructureDeployer does not have to extend
AbstractStructureDeployer, but we still want the trace
in the wrapper to show what is going on
because we can't trust the user written structure
to do any reasonable logging.
Alos, we don't want to see
[StructureDeployerWrapper] - unregonised x.jar
5 times!
Finally, you can't simply enable TRACE for
org.jboss.deployment.EARStructure
and see the useful StructureDeployerWrapper logging
if it is static.
- DML
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
10:20 a.m.
On Thu, 16 Aug 2007 17:22:38 +0200
Adrian <abrock(a)redhat.com> wrote:
On Thu, 2007-08-16 at 09:12 -0500, David M. Lloyd wrote:
> On Thu, 16 Aug 2007 14:51:44 +0200
> Adrian <abrock(a)redhat.com> wrote:
>
> >
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontaine...
>
> > 41 : private Logger log;
>
> Bleah - loggers really ought to be static. Creating a zillion loggers caused
> significant performance problems in vfs one time already.
>
There are only 5 structure deployers and each is a singleton.
OK. In this case though maybe a comment is in order:
"I solemnly swear that using an instance field for the Logger will
not cause a massive explosion of logger instances, because there will
only ever be five instances of this class."
:-)
- DML
5:11 a.m.
On Thu, 2007-08-16 at 17:22 +0200, Adrian wrote:
...
Alos, we don't want to see
[StructureDeployerWrapper] - unregonised x.jar
5 times!
...
Agreed for the end user, but if I see:
2007-08-16 14:13:00,258 TRACE [org.jboss.deployment.EARStructure:70] Not recognised:
ejb3_bb_stateless_enventry_ejb.jar
then I'm completely thrown off track.
What if it was changed into: log = Logger.getClass(StructureDeployerWrapper.class,
deployer.getClass().getName());
That would give:
[org.jboss.deployers.vfs.plugins.structure.StructureDeployerWrapper.org.jboss.deployment.EARStructure:70]
...
and
[EARStructure] ...
?
Carlo
6333
days inactive
6337
days old
jboss-development@lists.jboss.org
5 comments
3 participants
participants (3)
-
Adrian -
Carlo de Wolf -
David M. Lloyd