Can we avoid cutting releases for one-liner changes?

Move the fix to 5.0.1 with a note that yet another jboss-integration release would be needed.

Galder Zamarreno wrote: > Hi, > > I've just realised that I needed to add something else to > ServerVMClientUserTransaction in jboss-integration to fix this > inefficiency (https://jira.jboss.org/jira/browse/JBAS-5908) compared > to the solution for EAP. > > jboss-integration 5.0.0.GA has been tagged already but I have no > problem in fixing JBAS-5908 for 5.0.1, so can I commit the remaining > code in > https://svn.jboss.org/repos/jbossas/projects/integration/trunk/ ? Note > that I don't need to remove anything from the existing (partial) fix, > so no need to retag jboss-integration right now. > > Cheers, > > Dimitris Andreadis wrote: >> I've reverted partly, i.e. I've left the jboss-integration upgrade in. >> >> Galder Zamarreno wrote: >>> Dimitris, >>> >>> Can you revert rev 80237 from trunk? Seems like it introduced some >>> failures >>> (http://hudson.jboss.org/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-TestSui...) >>> that I need to verify. >>> >>> Thanks, >

On Fri, 2008-10-31 at 16:43 +0100, Galder Zamarreno wrote: > Hi, > > I've just realised that I needed to add something else to > ServerVMClientUserTransaction in jboss-integration to fix this > inefficiency (https://jira.jboss.org/jira/browse/JBAS-5908) compared to > the solution for EAP. > > jboss-integration 5.0.0.GA has been tagged already but I have no problem > in fixing JBAS-5908 for 5.0.1, so can I commit the remaining code in > https://svn.jboss.org/repos/jbossas/projects/integration/trunk/ ? Note > that I don't need to remove anything from the existing (partial) fix, so > no need to retag jboss-integration right now. > Argh! I said not to release it since I might have to do some changes for EJB3 to use UserTransactions correctly. Although I thought I could get away with not making changes in fact I have to. EJB3 can't use some of the necessary api that is in the appserver.

Fix tidied up. I tested a snapshot of jboss-integration with AS trunk and previously introduced regressions are not there any more. Adrian Brock wrote: > Galder, > > I've committed my stuff so it just needs to tidyup your fix > before we do a release of the integration project. > > On Mon, 2008-11-03 at 13:19 +0100, Adrian Brock wrote: >> On Fri, 2008-10-31 at 16:43 +0100, Galder Zamarreno wrote: >>> Hi, >>> >>> I've just realised that I needed to add something else to >>> ServerVMClientUserTransaction in jboss-integration to fix this >>> inefficiency (https://jira.jboss.org/jira/browse/JBAS-5908) compared to >>> the solution for EAP. >>> >>> jboss-integration 5.0.0.GA has been tagged already but I have no problem >>> in fixing JBAS-5908 for 5.0.1, so can I commit the remaining code in >>> https://svn.jboss.org/repos/jbossas/projects/integration/trunk/ ? Note >>> that I don't need to remove anything from the existing (partial) fix, so >>> no need to retag jboss-integration right now. >>> >> Argh! I said not to release it since I might have to do some >> changes for EJB3 to use UserTransactions correctly. >> >> Although I thought I could get away with not making changes >> in fact I have to. EJB3 can't use some of the necessary api that >> is in the appserver. >>