Re: [jboss-dev] Embedded Integration Suite by Default in AS Build

Nice tip. Though this is added complexity now; I don't think we need this profile at all. For the "embedded" module we should just configure Surefire to execute as part of the normal build lifecycle. This keeps things in line with Brian's "one switch to deactivate all tests in the suite" S, ALR On 06/04/2010 11:13 AM, Paul Gier wrote: > Hi Andrew, > > I recommend not using activeByDefault because the default behavior is that Maven > will deactivate this profile if another profile in the pom is activated [1]. > > What I normally do to make a profile active by default is to use a negative > property. So it the activation would look like this: > > <activation> > <property> > <name>!skip-tests</name> > </property> > </activation> > > That means the profile is active as long as "skip-tests" is not defined. > > [1]http://maven.apache.org/guides/introduction/introduction-to-profiles.html > > Andrew Lee Rubinger wrote: >> Good idea. >> >> I've set the profile to be active by default; excluding the tests is now >> the same as any Surefire-based execution (ie. -DskipTests=true). >> >> S, >> ALR >> >> On 06/03/2010 02:49 PM, Brian Stansberry wrote: >>> This should be done in a consistent manner; i.e. we enable/disable >>> running all the different modules' testsuites via one flag, not via a >>> bunch of different flags. >>> >>> On 06/03/2010 11:39 AM, Andrew Lee Rubinger wrote: >>>> This is now done: >>>> >>>> https://jira.jboss.org/browse/JBAS-8065 >>>> >>>> To speed up your build and skip the tests, run: >>>> >>>> mvn install -DskipEmbedded=true >>>> >>>> S, >>>> ALR >>>> >>>> On 06/03/2010 10:27 AM, Andrew Lee Rubinger wrote: >>>>> We've currently got a failing build in our AS/trunk Hudson runs due to a >>>>> regression in the Embedded module. >>>>> >>>>> In order to cut build time by default, I'd initially made the profile >>>>> which executes the Embedded integration suite disabled by default. It >>>>> is, however, a prerequisite to commit that we run this locally first. >>>>> >>>>> http://lists.jboss.org/pipermail/jboss-development/2010-April/016144.html >>>>> >>>>> For the sake of keeping the builds clean, I'm thinking it might make >>>>> more sense to enable these tests by default, and optionally skip them if >>>>> you provide a sysprop at the command-line: >>>>> >>>>> mvn install -DskipEmbedded=true >>>>> >>>>> Dissenting opinions? >>>>> >>>>> S, >>>>> ALR >>> >> > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development