well, as you know when it comes to spec (like TCP/IP):
- implement it so that you restrict yourself to the max, but
- accept more than the spec restrict you to
Now, pragmatically: will some significant number of people using jboss
have a "-" in their hostname? yes :) we are done.
On 10/10/2007 02:01 PM, Carlo de Wolf wrote:
In principal I don't agree. Just because some sly Fox is using an
OS
that doesn't stick to rules we shouldn't modify our code.
root@ubuntu:~# hostname ubuntu_test
hostname: the specified hostname is invalid
But it would appear that I'm being overtrumped.
Carlo
PS. This would make a great thread on memo-list.
On Wed, 2007-10-10 at 13:29 +0200, Sacha Labourey wrote:
> I agree with Tim here, is that in our code or in the the JDK's code?
>
> On 10/10/2007 12:46 PM, Tim Fox wrote:
>>
>> Carlo de Wolf wrote:
>>>
http://en.wikipedia.org/wiki/Hostname :
>>> "Underscore characters are commonly used by Windows systems but
>>> according to RFC 952 they are not allowed and several systems, such as
>>> DomainKeys and the SRV record deliberately use the underscore to make
>>> sure their special domain names are not confused with a hostname."
>> BTW I'm running Linux (FC6).
>>
>> Although if we go by the letter of the law we could disallow such
>> hostnames, I think the question here is whether we want to p off all
>> those JBAS 4.x users with underscores in their hostnames who try to
>> upgrade to JB5, hit this, and hate JBoss for ever... :)
>>> So we can add AS 5 to the list.
>>>
>>> Carlo
>>>
>>> On Wed, 2007-10-10 at 11:31 +0100, Tim Fox wrote:
>>>> Just tried to start JB5 on my laptop, and it fails.
>>>>
>>>> Seems like something in remoting doesn't like hostnames with an
>>>> underscore in them?
>>>>
>>>> My hostname is "tims_laptop".
>>>>
>>>> AS 4.x starts fine on the same machine.
>>>>
>>>> 11:05:17,197 ERROR [AbstractKernelController] Error installing to
>>>> Start: name=jboss.remoting:protocol=rmi,service=JMXConnectorServer
>>>> state=Create mode=Manual requiredState=Installed
>>>> java.net.MalformedURLException: Bad URL path:
>>>> _laptop/jndi/rmi://tims_laptop:1090/jmxconnector
>>>> at
>>>> javax.management.remote.JMXServiceURL.validate(JMXServiceURL.java:348)
>>>> at
>>>>
javax.management.remote.JMXServiceURL.<init>(JMXServiceURL.java:208)
>>>> at
>>>>
org.jboss.mx.remoting.service.JMXConnectorServerService.start(JMXConnectorServerService.java:106)
>>>>
>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>> at
>>>>
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>>
>>>> at
>>>>
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>>
>>>> at java.lang.reflect.Method.invoke(Method.java:585)
>>>> at
>>>>
org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
>>>>
>>>> at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
>>>> at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
>>>> at
>>>>
org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
>>>>
>>>> at
>>>> org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
>>>> at
>>>>
org.jboss.system.microcontainer.ServiceProxy.invoke(ServiceProxy.java:184)
>>>>
>>>> at $Proxy4.start(Unknown Source)
>>>> at
>>>>
org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:42)
>>>>
>>>> at
>>>>
org.jboss.system.microcontainer.ServiceControllerContextAction.install(ServiceControllerContextAction.java:46)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractControllerContextActions.install(AbstractControllerContextActions.java:51)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:327)
>>>>
>>>> at
>>>>
org.jboss.system.microcontainer.ServiceControllerContext.install(ServiceControllerContext.java:239)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1309)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:734)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:862)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:784)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:622)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:411)
>>>>
>>>> at
>>>> org.jboss.system.ServiceController.doChange(ServiceController.java:659)
>>>> at
>>>> org.jboss.system.ServiceController.start(ServiceController.java:431)
>>>> at
>>>>
org.jboss.system.deployers.ServiceDeployer.start(ServiceDeployer.java:149)
>>>>
>>>> at
>>>>
org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:107)
>>>>
>>>> at
>>>>
org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:46)
>>>>
>>>> at
>>>>
org.jboss.deployers.spi.deployer.helpers.AbstractSimpleRealDeployer.deploy(AbstractSimpleRealDeployer.java:65)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:169)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:728)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:749)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:669)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:327)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1309)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:734)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:862)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:784)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:622)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:411)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:495)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:354)
>>>>
>>>> at
>>>>
org.jboss.system.server.profileservice.ProfileServiceBootstrap.loadProfile(ProfileServiceBootstrap.java:245)
>>>>
>>>> at
>>>>
org.jboss.system.server.profileservice.ProfileServiceBootstrap.start(ProfileServiceBootstrap.java:131)
>>>>
>>>> at
>>>> org.jboss.bootstrap.AbstractServerImpl.start(AbstractServerImpl.java:382)
>>>>
>>>> at org.jboss.Main.boot(Main.java:210)
>>>> at org.jboss.Main$1.run(Main.java:529)
>>>> at java.lang.Thread.run(Thread.java:595)
>>>> 11:05:17,203 ERROR [AbstractKernelController] Error installing to
>>>> Real:
>>>>
name=vfsfile:/home/tim/dev/jbas/trunk/build/output/jboss-5.0.0.Beta3/server/default/deploy/jmx-remoting.sar/
>>>> state=PostClassLoader mode=Manual requiredState=Real
>>>> org.jboss.deployers.spi.DeploymentException: Error deploying:
>>>> jboss.remoting:service=JMXConnectorServer,protocol=rmi
>>>> at
>>>>
org.jboss.deployers.spi.DeploymentException.rethrowAsDeploymentException(DeploymentException.java:49)
>>>>
>>>> at
>>>>
org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:126)
>>>>
>>>> at
>>>>
org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:46)
>>>>
>>>> at
>>>>
org.jboss.deployers.spi.deployer.helpers.AbstractSimpleRealDeployer.deploy(AbstractSimpleRealDeployer.java:65)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:169)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:728)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:749)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:669)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:327)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1309)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:734)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:862)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:784)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:622)
>>>>
>>>> at
>>>>
org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:411)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:495)
>>>>
>>>> at
>>>>
org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:354)
>>>>
>>>> at
>>>>
org.jboss.system.server.profileservice.ProfileServiceBootstrap.loadProfile(ProfileServiceBootstrap.java:245)
>>>>
>>>> at
>>>>
org.jboss.system.server.profileservice.ProfileServiceBootstrap.start(ProfileServiceBootstrap.java:131)
>>>>
>>>> at
>>>> org.jboss.bootstrap.AbstractServerImpl.start(AbstractServerImpl.java:382)
>>>>
>>>> at org.jboss.Main.boot(Main.java:210)
>>>> at org.jboss.Main$1.run(Main.java:529)
>>>> at java.lang.Thread.run(Thread.java:595)
>>>>
>>>>
>>> _______________________________________________
>>> jboss-development mailing list
>>> jboss-development(a)lists.jboss.org
>>>
https://lists.jboss.org/mailman/listinfo/jboss-development
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/jboss-development
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development