David, while there, I think org.jboss.logbridge.LogNotificationListener should subscribe
for
the specific "jboss.logging.log4j.reconfigure" notification type. The way it is
now the
service would reconfigure itself when receiving notifications from Log4jService's
ServiceMBeanSupport base class.
In addition, maybe you could provide also an MBean with equivalent functionality that is
deployed together with Log4jService and they are in the same conf/jboss-service.xml file,
for now.
When Log4jService gets POJOized, we could change it again.
David M. Lloyd wrote:
On 03/09/2009 04:56 AM, Dimitris Andreadis wrote:
> David M. Lloyd wrote:
>> In order to facilitate the JMX notification part, I added a
>> logbridge-jboss-beans.xml to deployers/, which is kind of a sucky
>> place to add this but I couldn't think of a better one (most of the
>> server stuff is still JMX-based so there's no likely jboss-beans.xml
>> to add stuff to). If anyone has any better ideas, let me know - or
>> better yet, just go ahead and move it. :-)
>
> It had the wrong suffix, so I've renamed it:
> Added:
> branches/Branch_5_x/server/src/etc/deployers/logbridge-jboss-beans.xml
> Removed:
> branches/Branch_5_x/server/src/etc/deployers/logbridge-jboss.beans.xml
Ah, guess that's what happens when I work on a Saturday.
> Would it still work if you move it to conf/bootstrap/logging.xml?
No, it depends on JMX being started for one (which happens later in
bootstrap), whereas logging.xml installs itself first thing in order to
grab JDK logging messages early on. I did try this initially, hoping
that I could come up with some way to defer the bean installation until
the dependencies had been met but I couldn't make it work. We could add
a later bootstrap phase for it, but that doesn't seem all that different
from what I'm doing now in terms of timing.
- DML
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development