Ales, The Embedded tests run in the AS Build are failing with this change: http://hudson.jboss.org/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x/1646/co... I've attached the output of the test. To reproduce, build jbossas/trunk passing -Pembedded Shelly McGowan JBoss, by Red Hat ----- Original Message ----- From: "Ales Justin" <ales.justin(a)gmail.com&gt; To: "JBoss.org development list" <jboss-development(a)lists.jboss.org&gt; Cc: "Pete Muir" <pmuir(a)redhat.com&gt;, "Remy Maucherat" <rmaucher(a)redhat.com&gt; Sent: Wednesday, June 2, 2010 9:26:32 AM GMT -05:00 US/Canada Eastern Subject: [jboss-dev] new scanning in AS trunk I've just updated the AS trunk with new Scanning lib. It also includes some other MC changes: Reflect, MDR, Kernel, CL, Deployers. Apart from AnnotationRepository (which was already there with the old code), I've also hacked around Hibernate's Scanner a bit, so it uses new scanning lib's ScannerImpl. (the hack is mostly in place due to some impl issues in Hibernate itself, Emmanuel is working on it) JSF can now use new JBossAnnotationProvider -- let me know how that goes Stan. And web can use ResourcesIndex from DeploymentUnit -- Remy. WeldScanningPlugin is currently commented out. We need to disable one of the deployers in plugin's favor. Pete, let me know when the new Weld release is coming in, and I'll enable the plugin + run a few tests. All in all, if you spot any issues / regressions wrt this change, let me know, and I'll try to fix the stuff asap. _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development <org.jboss.jbossas.embedded.testsuite.ServerIntegrationTest-output.txt>_______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

Ales Justin wrote: > The Embedded needs to set this system property > > // TODO -- remove this once we have Javassist Reflect performance fixed > String tif = System.getProperty("org.jboss.reflect.spi.TypeInfoFactory"); > if (tif == null) > System.setProperty("org.jboss.reflect.spi.TypeInfoFactory", "org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactory"); > Looking at that TODO it looks temporary and a very specific config param to jboss.reflect. If a system property is required, then maybe it could be handled/added within the jboss-reflect project which knows the details about what this config is for? That way, numerous dependent projects need not change/add the param. regards, -Jaikiran > Where do you do this for Embedded? > > btw, thanks for the info Shelly. > > -Ales > > On Jun 2, 2010, at 5:14 PM, Shelly McGowan wrote: > >> Ales, >> >> The Embedded tests run in the AS Build are failing with this change: >> >> http://hudson.jboss.org/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x/1646/co... >> >> I've attached the output of the test. >> >> To reproduce, build jbossas/trunk passing -Pembedded >> >> Shelly McGowan >> JBoss, by Red Hat >> >> ----- Original Message ----- >> From: "Ales Justin" <ales.justin(a)gmail.com&gt; >> To: "JBoss.org development list" <jboss-development(a)lists.jboss.org&gt; >> Cc: "Pete Muir" <pmuir(a)redhat.com&gt;, "Remy Maucherat" <rmaucher(a)redhat.com&gt; >> Sent: Wednesday, June 2, 2010 9:26:32 AM GMT -05:00 US/Canada Eastern >> Subject: [jboss-dev] new scanning in AS trunk >> >> I've just updated the AS trunk with new Scanning lib. >> It also includes some other MC changes: Reflect, MDR, Kernel, CL, Deployers. >> >> Apart from AnnotationRepository (which was already there with the old code), >> I've also hacked around Hibernate's Scanner a bit, so it uses new scanning lib's ScannerImpl. >> (the hack is mostly in place due to some impl issues in Hibernate itself, Emmanuel is working on it) >> >> JSF can now use new JBossAnnotationProvider -- let me know how that goes Stan. >> And web can use ResourcesIndex from DeploymentUnit -- Remy. >> >> WeldScanningPlugin is currently commented out. >> We need to disable one of the deployers in plugin's favor. >> Pete, let me know when the new Weld release is coming in, >> and I'll enable the plugin + run a few tests. >> >> All in all, if you spot any issues / regressions wrt this change, >> let me know, and I'll try to fix the stuff asap. >> >> >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development >> <org.jboss.jbossas.embedded.testsuite.ServerIntegrationTest-output.txt>_______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development > > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

Embedded resides here http://anonsvn.jboss.org/repos/jbossas/projects/embedded/trunk but it's mainly backed by the bootstrap impl-as module which sets most of the system properties in JBossASServerInitializer http://anonsvn.jboss.org/repos/jbossas/projects/bootstrap/trunk/impl-as/s.... So I _think_ that's where this would go. ALR would definitely know. I haven't yet tried adding that property to bootstrap (although I can try it sometime later if no one else gets to it before me). regards, -Jaikiran Ales Justin wrote: > I'll revert to Introspection by default tomorrow. > And I'll check why the value convert fails if running in Javassist mode. > > Meanwhile, can someone just add the same property to Embedded, > and let me know where this is, so I can remove it after I update Reflect. > > -Ales > > On Jun 2, 2010, at 5:37 PM, Jaikiran Pai wrote: > >> Ales Justin wrote: >>> The Embedded needs to set this system property >>> >>> // TODO -- remove this once we have Javassist Reflect performance fixed >>> String tif = >>> System.getProperty("org.jboss.reflect.spi.TypeInfoFactory"); >>> if (tif == null) >>> System.setProperty("org.jboss.reflect.spi.TypeInfoFactory", >>> "org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactory"); >>> >>> >> Looking at that TODO it looks temporary and a very specific config >> param to jboss.reflect. If a system property is required, then maybe >> it could be handled/added within the jboss-reflect project which >> knows the details about what this config is for? That way, numerous >> dependent projects need not change/add the param. >> >> >> regards, >> -Jaikiran >>> Where do you do this for Embedded? >>> >>> btw, thanks for the info Shelly. >>> >>> -Ales >>> >>> On Jun 2, 2010, at 5:14 PM, Shelly McGowan wrote: >>> >>>> Ales, >>>> >>>> The Embedded tests run in the AS Build are failing with this change: >>>> >>>> http://hudson.jboss.org/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x/1646/co... >>>> >>>> >>>> I've attached the output of the test. >>>> >>>> To reproduce, build jbossas/trunk passing -Pembedded >>>> >>>> Shelly McGowan >>>> JBoss, by Red Hat >>>> >>>> ----- Original Message ----- >>>> From: "Ales Justin" <ales.justin(a)gmail.com&gt; >>>> To: "JBoss.org development list" <jboss-development(a)lists.jboss.org&gt; >>>> Cc: "Pete Muir" <pmuir(a)redhat.com&gt;, "Remy Maucherat" >>>> <rmaucher(a)redhat.com&gt; >>>> Sent: Wednesday, June 2, 2010 9:26:32 AM GMT -05:00 US/Canada Eastern >>>> Subject: [jboss-dev] new scanning in AS trunk >>>> >>>> I've just updated the AS trunk with new Scanning lib. >>>> It also includes some other MC changes: Reflect, MDR, Kernel, CL, >>>> Deployers. >>>> >>>> Apart from AnnotationRepository (which was already there with the >>>> old code), >>>> I've also hacked around Hibernate's Scanner a bit, so it uses new >>>> scanning lib's ScannerImpl. >>>> (the hack is mostly in place due to some impl issues in Hibernate >>>> itself, Emmanuel is working on it) >>>> >>>> JSF can now use new JBossAnnotationProvider -- let me know how that >>>> goes Stan. >>>> And web can use ResourcesIndex from DeploymentUnit -- Remy. >>>> >>>> WeldScanningPlugin is currently commented out. >>>> We need to disable one of the deployers in plugin's favor. >>>> Pete, let me know when the new Weld release is coming in, >>>> and I'll enable the plugin + run a few tests. >>>> >>>> All in all, if you spot any issues / regressions wrt this change, >>>> let me know, and I'll try to fix the stuff asap. >>>> >>>> >>>> _______________________________________________ >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>>> <org.jboss.jbossas.embedded.testsuite.ServerIntegrationTest-output.txt>_______________________________________________ >>>> >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>> >>> _______________________________________________ >>> jboss-development mailing list >>> jboss-development(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jboss-development >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development >

> 1) Why is this property required for Embedded and not AS standalone? It's already been put in Main or run.conf? Yes, it's already part of Main. > 2) At what phase of the server lifecycle does this property need to be set? The first usage of Reflect's TypeInfoFactory. > I'm having a look, but locally on r105583 I don't see any issue w.r.t. the JBREFLECT stuff in the Embedded suite. This run will tell me more when it completes: > > http://jboss.hudson.alrubinger.com/job/AS_TestSuite_Trunk_Smoke_Tests/132/ > > Overall, I don't want to introduce a hack sysprop setting into Embedded, release it, remove the hack, then release it again. It'd make for an improper release of EMB, not to mention a waste of time. No need, like I said, I'll do a new Reflect release with Introspection as default asap.

> Everyone must run the AS build in -Pembedded as well as smoke-tests before committing. :) Else the breakages become eligible for rollback. Noted. ;-)

> I was about to alter the Surefire config of jbossas/trunk/embedded to put the property in there. I think that's the right place for our hack ATM if you run into issues w/ a new Reflect release. If it's just a Surefire config property, go ahead, so we can get a few test runs till tomorrow. Meanwhile I'll check and fix the Reflect.

Meanwhile I'll check and fix the Reflect.