5:39 p.m.
I would rather use the forums for this... But I will use this list since
it is down.
Why the resource adapter is hard coded on
org.jboss.ejb3.mdb.MessagingContainer?
For instance i was going to rename it for JBM2, since we have our own
provider now, but i couldn't as there is this hard-coded instance. What
if the user was using another JMS provider besides JBM, JBM2 or JBossMQ?
It seems that this was supposed to be used around creating JMS
Destinations when deploying MDBs, but as far as I remember that feature
was Brocked long ago, so this code could probably be removed?
I couldn't understand back then the reasons for the Adrian Brocking it,
but it would be possible to do such thing on the resourceI would rather
use the forums for this... But I will use this list since it is down.
Why the resource adapter is hard coded on
org.jboss.ejb3.mdb.MessagingContainer?
For instance i was going to rename it for JBM2, since we have our own
provider now, but i couldn't as there is this hard-coded instance. What
if the user was using another JMS provider besides JBM, JBM2 or JBossMQ?
It seems that this was supposed to be used around creating non existent
when deploying MDBs, but as far as I remember that feature was Brocked
long ago, so this code could probably be removed?
I couldn't understand Adrian's reasons back then, but it seems
impossible to do it generically. If we want such thing we could
implement it on the ResourceAdapter, but I think it would be just better
to let the user aways deploy its destinations.
There are other references in two other xmls:
/jboss-5.1.0.CR1/server/default/deployers/ejb-deployer-jboss-beans.xml:
<!-- Destination creator for JBoss Messaging -->
<bean name="JBossMessageDestinationCreator"
class="org.jboss.ejb.deployers.CreateDestination">
<!-- We match any jms mdb that is going to be deployed using our
rar -->
<property name="matcher">
<bean
class="org.jboss.ejb.deployers.SimpleCreateDestinationMatcher">
<property name="default">true</property>
<property
name="messageListener">javax.jms.MessageListener</property>
<property name="rarName">jms-ra.rar</property>
</bean>
</property>
<!-- Create a destination with JBoss Messaging -->
<property name="factory">
<bean
class="org.jboss.jms.server.destination.JBossMessagingCreateDestinationFactory">
<property
name="serverPeerName">jboss.messaging:service=ServerPeer</property>
<property
name="postOfficeName">jboss.messaging:service=PostOffice</property>
</bean>
</property>
</bean>
jboss-5.1.0.CR1/server/default/deployers/metadata-deployer-jboss-beans.xml:
<bean name="JBossCustomDeployDUFilter"
class="org.jboss.deployers.vfs.spi.structure.helpers.VirtualFileDeploymentUnitFilter">
<constructor>
<parameter>
<bean class="org.jboss.deployment.FileNameVirtualFileFilter">
<constructor>
....
<entry>
<key>jms-ra.rar</key>
<value><null/></value>
</entry>
There are other references in two other xmls:
/jboss-5.1.0.CR1/server/default/deployers/ejb-deployer-jboss-beans.xml:
<!-- Destination creator for JBoss Messaging -->
<bean name="JBossMessageDestinationCreator"
class="org.jboss.ejb.deployers.CreateDestination">
<!-- We match any jms mdb that is going to be deployed using our
rar -->
<property name="matcher">
<bean
class="org.jboss.ejb.deployers.SimpleCreateDestinationMatcher">
<property name="default">true</property>
<property
name="messageListener">javax.jms.MessageListener</property>
<property name="rarName">jms-ra.rar</property>
</bean>
</property>
<!-- Create a destination with JBoss Messaging -->
<property name="factory">
<bean
class="org.jboss.jms.server.destination.JBossMessagingCreateDestinationFactory">
<property
name="serverPeerName">jboss.messaging:service=ServerPeer</property>
<property
name="postOfficeName">jboss.messaging:service=PostOffice</property>
</bean>
</property>
</bean>
jboss-5.1.0.CR1/server/default/deployers/metadata-deployer-jboss-beans.xml:
<bean name="JBossCustomDeployDUFilter"
class="org.jboss.deployers.vfs.spi.structure.helpers.VirtualFileDeploymentUnitFilter">
<constructor>
<parameter>
<bean class="org.jboss.deployment.FileNameVirtualFileFilter">
<constructor>
....
<entry>
<key>jms-ra.rar</key>
<value><null/></value>
</entry>
Clebert
5:48 p.m.
I had a problem with Copy&paste on this message right before pressing
send.. sending it again (sorry for the dup):
I would rather use the forums for this... But I will use this list since
it is down.
Why the resource adapter is hard coded on
org.jboss.ejb3.mdb.MessagingContainer?
For instance i was going to rename it for JBM2, since we have our own
provider now, but i couldn't as there is this hard-coded instance. What
if the user was using another JMS provider besides JBM, JBM2 or JBossMQ?
It seems that this was supposed to be used around creating non existent
when deploying MDBs, but as far as I remember that feature was Brocked
long ago, so this code could probably be removed?
I couldn't understand Adrian's reasons back then, but it seems
impossible to do it generically. If we want such thing we could
implement it on the ResourceAdapter, but I think it would be just better
to let the user aways deploy its destinations.
There are other references in two other xmls:
/jboss-5.1.0.CR1/server/default/deployers/ejb-deployer-jboss-beans.xml:
<!-- Destination creator for JBoss Messaging -->
<bean name="JBossMessageDestinationCreator"
class="org.jboss.ejb.deployers.CreateDestination">
<!-- We match any jms mdb that is going to be deployed using our
rar -->
<property name="matcher">
<bean
class="org.jboss.ejb.deployers.SimpleCreateDestinationMatcher">
<property name="default">true</property>
<property
name="messageListener">javax.jms.MessageListener</property>
<property name="rarName">jms-ra.rar</property>
</bean>
</property>
<!-- Create a destination with JBoss Messaging -->
<property name="factory">
<bean
class="org.jboss.jms.server.destination.JBossMessagingCreateDestinationFactory">
<property
name="serverPeerName">jboss.messaging:service=ServerPeer</property>
<property
name="postOfficeName">jboss.messaging:service=PostOffice</property>
</bean>
</property>
</bean>
jboss-5.1.0.CR1/server/default/deployers/metadata-deployer-jboss-beans.xml:
<bean name="JBossCustomDeployDUFilter"
class="org.jboss.deployers.vfs.spi.structure.helpers.VirtualFileDeploymentUnitFilter">
<constructor>
<parameter>
<bean class="org.jboss.deployment.FileNameVirtualFileFilter">
<constructor>
....
<entry>
<key>jms-ra.rar</key>
<value><null/></value>
</entry>
6:24 a.m.
Clebert Suconic wrote:
Why the resource adapter is hard coded on
org.jboss.ejb3.mdb.MessagingContainer?
You mean the jms-ra.rar filename right?
For instance i was going to rename it for JBM2, since we have our own
provider now, but i couldn't as there is this hard-coded instance.
Not really
a solution to what you are trying to achieve (i.e. removing
dependency on the file names), but I think we (EJB3) can move the
hardcoding out of the MessagingContainer and instead introduce this as
an annotation through ejb3-interceptors-aop.xml:
<domain name="Message Driven Bean" extends="Intercepted Bean"
inheritBindings="true">
...
<annotation expr="class(*) AND
!class((a)org.jboss.ejb3.annotation.ResourceAdapter)">
@org.jboss.ejb3.annotation.ResourceAdapter ("jms-ra.rar")
</annotation>
</domain>
What if the user was using another JMS provider besides JBM, JBM2 or
JBossMQ?
The ResourceAdapter can be overriden by using the
@org.jboss.ejb3.annotation.ResourceAdapter on the MDB:
@ResourceAdapter("somecustom-ra.rar")
public class MyMDB
{
...
}
It seems that this was supposed to be used around creating non
existent when deploying MDBs,
Not sure.
but as far as I remember that feature was Brocked long ago, so this
code could probably be removed?
Creation of non-existent destinations is now
available through a
property https://jira.jboss.org/jira/browse/JBAS-6013
regards,
-Jaikiran
7:29 a.m.
It looks like the Create Destination is abstracted in another class.
Why do you need to rar-name on the MessagingContainer then? You guys are
just using JMS, and the destination creation is abstracted. So, it looks
like all you needed was the ConnectionFactoryName to the JCA adaptor,
and you would just need to call the CreateDestinationMatcher somehow.
Jaikiran Pai wrote:
Clebert Suconic wrote:
>
> Why the resource adapter is hard coded on
> org.jboss.ejb3.mdb.MessagingContainer?
You mean the jms-ra.rar filename right?
>
> For instance i was going to rename it for JBM2, since we have our own
> provider now, but i couldn't as there is this hard-coded instance.
Not really a solution to what you are trying to achieve (i.e. removing
dependency on the file names), but I think we (EJB3) can move the
hardcoding out of the MessagingContainer and instead introduce this as
an annotation through ejb3-interceptors-aop.xml:
<domain name="Message Driven Bean" extends="Intercepted Bean"
inheritBindings="true">
...
<annotation expr="class(*) AND
!class((a)org.jboss.ejb3.annotation.ResourceAdapter)">
@org.jboss.ejb3.annotation.ResourceAdapter ("jms-ra.rar")
</annotation>
</domain>
> What if the user was using another JMS provider besides JBM, JBM2 or
> JBossMQ?
The ResourceAdapter can be overriden by using the
@org.jboss.ejb3.annotation.ResourceAdapter on the MDB:
@ResourceAdapter("somecustom-ra.rar")
public class MyMDB
{
...
}
> It seems that this was supposed to be used around creating non
> existent when deploying MDBs,
Not sure.
> but as far as I remember that feature was Brocked long ago, so this
> code could probably be removed?
Creation of non-existent destinations is now available through a
property https://jira.jboss.org/jira/browse/JBAS-6013
regards,
-Jaikiran
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
7:49 a.m.
From what i see in the code
(org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec())
the only reason why the rar-name is being used is to get hold of the
resource adapter MBean for creating the activation spec. I think the
dependency on the rar-name can be removed if we somehow can add a
dependency/inject on the correct resource adapter MBean. I personally
don't know if there is any other dependency on the rar-name.
-Jaikiran
Clebert Suconic wrote:
It looks like the Create Destination is abstracted in another class.
Why do you need to rar-name on the MessagingContainer then? You guys
are just using JMS, and the destination creation is abstracted. So, it
looks like all you needed was the ConnectionFactoryName to the JCA
adaptor, and you would just need to call the CreateDestinationMatcher
somehow.
Jaikiran Pai wrote:
> Clebert Suconic wrote:
>>
>> Why the resource adapter is hard coded on
>> org.jboss.ejb3.mdb.MessagingContainer?
> You mean the jms-ra.rar filename right?
>>
>> For instance i was going to rename it for JBM2, since we have our
>> own provider now, but i couldn't as there is this hard-coded instance.
> Not really a solution to what you are trying to achieve (i.e.
> removing dependency on the file names), but I think we (EJB3) can
> move the hardcoding out of the MessagingContainer and instead
> introduce this as an annotation through ejb3-interceptors-aop.xml:
>
> <domain name="Message Driven Bean" extends="Intercepted Bean"
> inheritBindings="true">
> ...
> <annotation expr="class(*) AND
> !class((a)org.jboss.ejb3.annotation.ResourceAdapter)">
> @org.jboss.ejb3.annotation.ResourceAdapter ("jms-ra.rar")
> </annotation>
> </domain>
>
>> What if the user was using another JMS provider besides JBM, JBM2 or
>> JBossMQ?
> The ResourceAdapter can be overriden by using the
> @org.jboss.ejb3.annotation.ResourceAdapter on the MDB:
>
> @ResourceAdapter("somecustom-ra.rar")
> public class MyMDB
> {
> ...
> }
>
>> It seems that this was supposed to be used around creating non
>> existent when deploying MDBs,
> Not sure.
>> but as far as I remember that feature was Brocked long ago, so this
>> code could probably be removed?
> Creation of non-existent destinations is now available through a
> property https://jira.jboss.org/jira/browse/JBAS-6013
>
> regards,
> -Jaikiran
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
8:11 a.m.
From what i see in the code
(org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec())
the only reason why the rar-name is being used is to get hold of the
resource adapter MBean for creating the activation spec.
Isn' t there a better way of doing this?
It sounds like a hack to me. the rar-name is already specified on the
tx-connection-factory, and the MDB has a reference to the factory being
used, so IMO you shouldn' t need any other reference to the rar. JCA
should provide you some decent way of getting what you needed without
adding the hard link.
Jesper: What do you think?
9:55 a.m.
On Thursday 23 April 2009 09:11:28 Clebert Suconic wrote:
> From what i see in the code
(org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec
()) the only reason why the rar-name is being used is to get hold of the
resource adapter MBean for creating the activation spec.
Isn' t there a better way of doing this?
It sounds like a hack to me. the rar-name is already specified on the
tx-connection-factory, and the MDB has a reference to the factory being
used, so IMO you shouldn' t need any other reference to the rar. JCA
should provide you some decent way of getting what you needed without
adding the hard link.
Jesper: What do you think?
There are plans to include a JBoss JCA SPI in the new container implementation
such that these integration issues can be easier fix.
MDBs is of course one of the use-cases.
Best regards,
Jesper
10:31 a.m.
https://jira.jboss.org/jira/browse/JBAS-6820
I would have marked it as blocker. I set it for Critical for now.
Jesper Pedersen wrote:
On Thursday 23 April 2009 09:11:28 Clebert Suconic wrote:
> > From what i see in the code
>
> (org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec
> ()) the only reason why the rar-name is being used is to get hold of the
> resource adapter MBean for creating the activation spec.
>
> Isn' t there a better way of doing this?
>
> It sounds like a hack to me. the rar-name is already specified on the
> tx-connection-factory, and the MDB has a reference to the factory being
> used, so IMO you shouldn' t need any other reference to the rar. JCA
> should provide you some decent way of getting what you needed without
> adding the hard link.
>
> Jesper: What do you think?
>
There are plans to include a JBoss JCA SPI in the new container implementation
such that these integration issues can be easier fix.
MDBs is of course one of the use-cases.
Best regards,
Jesper
10:33 a.m.
This would need to be fixed before AS 5.1.
Since without this fix, we can't use JBM 2.0 properly in AS 5.1.
JBM 2.0 is on the roadmap for EAP 5.1, and EAP 5.1 will consume AS 5.1.
So.. you guys got a couple of days to sort it out before code freeze. :)
Jesper Pedersen wrote:
On Thursday 23 April 2009 09:11:28 Clebert Suconic wrote:
> > From what i see in the code
>
> (org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec
> ()) the only reason why the rar-name is being used is to get hold of the
> resource adapter MBean for creating the activation spec.
>
> Isn' t there a better way of doing this?
>
> It sounds like a hack to me. the rar-name is already specified on the
> tx-connection-factory, and the MDB has a reference to the factory being
> used, so IMO you shouldn' t need any other reference to the rar. JCA
> should provide you some decent way of getting what you needed without
> adding the hard link.
>
> Jesper: What do you think?
>
There are plans to include a JBoss JCA SPI in the new container implementation
such that these integration issues can be easier fix.
MDBs is of course one of the use-cases.
Best regards,
Jesper
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
--
Tim Fox
Messaging Lead
JBoss - a division of Red Hat
http://jbossfox.blogspot.com/
irc.freenode.net#jbossmessaging
fox(a)redhat.com
3:51 p.m.
As I talked to Andrew and Carlo on IRC:
All the ActivactionProperties are just passed the ResourceAdapter. so,
the user can configure anything he wants on those ActivationProperties,
and we just document those on our resource-adaptor.
In regard to the rar-name, that's just the default. There is another tag
where that could be specified. (I've already rejected the JIRA).
thanks for clearing that up.
Clebert
Tim Fox wrote:
This would need to be fixed before AS 5.1.
Since without this fix, we can't use JBM 2.0 properly in AS 5.1.
JBM 2.0 is on the roadmap for EAP 5.1, and EAP 5.1 will consume AS 5.1.
So.. you guys got a couple of days to sort it out before code freeze. :)
Jesper Pedersen wrote:
> On Thursday 23 April 2009 09:11:28 Clebert Suconic wrote:
>
>> > From what i see in the code
>>
>> (org.jboss.ejb3.mdb.inflow.JBossMessageEndpointFactory.createActivationSpec
>>
>> ()) the only reason why the rar-name is being used is to get hold of
>> the
>> resource adapter MBean for creating the activation spec.
>>
>> Isn' t there a better way of doing this?
>>
>> It sounds like a hack to me. the rar-name is already specified on the
>> tx-connection-factory, and the MDB has a reference to the factory being
>> used, so IMO you shouldn' t need any other reference to the rar. JCA
>> should provide you some decent way of getting what you needed without
>> adding the hard link.
>>
>> Jesper: What do you think?
>>
>
> There are plans to include a JBoss JCA SPI in the new container
> implementation such that these integration issues can be easier fix.
>
> MDBs is of course one of the use-cases.
>
> Best regards,
> Jesper
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
6068
days inactive
6069
days old
jboss-development@lists.jboss.org
9 comments
4 participants
participants (4)
-
Clebert Suconic -
Jaikiran Pai -
Jesper Pedersen -
Tim Fox