Re: [jboss-dev] throws Throwable

Andrew Lee Rubinger wrote: > Just because it's generic doesn't mean the caller can do anything > about it. In that case why not just "throws Exception"? As per javax.interceptor.InvocationContext.proceed(). But InvocationHandler.invoke throws a Throwable, which I think is wrong. It seems that the important bit is how the caller is excepted to behave. I think Joshua Bloch sums it up nicely with "use checked exception for recoverable conditions and run-time exceptions for programming errors". Tim's example shows a poor storeMessage implementation, because the implementer forced the problem onto the caller instead of solving it. > > BTW as practice lately I tend to declare and document unchecked > exceptions to give the user a clear idea of what to expect, ie: > > /** > * @throws IllegalStateException If not yet initialized > * @throws IllegalArgumentException If you gave me null, bastard > */ > myMethod(String arg) throws IllegalStateException, > IllegalArgumentException{} > > S, > ALR > The only thing is that the guideline above invalidates IllegalStateException and IllegalArgumentException, because both are generally recoverable and are RuntimeExceptions. In those cases I would say that you should add boolean isValid(...) and boolean canStart(...), because then it becomes a programming error again to call myMethod wrongly.