RE: [JBoss-dev]InstanceAlreadyExistsExceptionafterundeployandrepeateddeployin JBoss AS 5.0.0 Beta
I think my 'Mom' analogy was a bad idea, as I'm losing track of the real
meaning of the conversation :) My post was that way too.
1) Having the new implementation clean up after people is good. I
didn't mean to imply it wasn't.
2) Jason, are you proposing that if Controller unregisters an MBean it
didn't register, it should complain a bit (i.e. log a WARN or
something)?
3) IMHO having EjbModule call registerMBean and then not clean up after
itself is bad. Does anyone who is more familiar with EJB 2 deployments
see any reason not to call unregisterMBean() in
EjbModule.destroyService()? (Harder alternative is figure out how to get
rid of the registerMBean call in createService()).
I'll shut up now; probably this is something that will be sorted as part
of updating the deployers. My concern was getting the HA-JNDI unit test
working, which Adrian kindly did :)
jboss-development-bounces(a)lists.jboss.org wrote:
Right, so why don't we complain if they don't clean up after
themselves, and then clean up for them? Just like Mom does.
> -----Original Message-----
> From: jboss-development-bounces(a)lists.jboss.org
> [mailto:jboss-development- bounces(a)lists.jboss.org] On Behalf Of
> Brian Stansberry
> Sent: Wednesday, August 16, 2006 11:20 AM
> To: JBoss.org development list
> Subject: RE: [JBoss-
> dev]InstanceAlreadyExistsExceptionafterundeployandrepeated deployin
> JBoss AS 5.0.0 Beta
>
> jboss-development-bounces(a)lists.jboss.org wrote:
>> On Wed, 2006-08-16 at 15:49 +0200, Adrian Brock wrote:
>>> Also, this change causes "problems" for web deployments (looks
like
>>> they being unregistered from the MBeanServer rather than being
>>> removed from the ServiceController?):
>>>
>>
>> Yep. And I've fixed this as well.
>
> So, before ServiceController.remove() was cleaning up after people,
> and now the new implementation is again. And you just fixed an
> issue where it would complain if people had already cleaned up after
> themselves :)
>
> If need be my mom used to clean up after me, but she also trained me
> to clean up after myself (well, kinda). So, seems like if
> EjbModule.createService() is going to call registerMBean(),
> EjbModule.destroyService() should call unregisterMBean().
>
> Brian Stansberry
> Lead, AS Clustering
> JBoss, a division of Red Hat
> Ph: 510-396-3864
> skype: bstansberry
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry