Re: [jboss-dev] Help fix the testsuite or we rollback to r79434

On Mon, 2008-10-20 at 14:46 +0100, Kabir Khan wrote: > I wish this had been done before... Now more people, myself included, > will have to waste time reapplying more stuff. > > Yes, we definitely need to rollback earlier, we shouldn't let things build up for more than a day. If the testsuite is broken due to major refactoring, we should fix it on a branch not trunk so that others can work. On a practical point, I'd suggest you monitor hudson before committing and delay your commit if the testsuite looks broken. I've attached a list of all the changes that got rolled back. I generated this list using the following script run from the root from a jboss trunk checkout: for ((i=79434; i<=79744; i+=1)); do svn log -r $i; done 2>&1 > rollback.log Maybe there is a more efficient way to achieve the same thing? > On 20 Oct 2008, at 14:24, Dimitris Andreadis wrote: > > >> At this point I need to rollback everyones changes. When did you >> created your branch? I did a quick test after your commit and it >> wasn't booting properly... >> >> Richard Opalka wrote: >> >>> Hi Dimitris, >>> don't rollback my JBAS-6004 change, please. I tested it many hours >>> before commiting it to the AS trunk. >>> Cheers, >>> Richard >>> Dimitris Andreadis wrote: >>> >>>> It's monday and the testsuite is still in a bad shape, so I'm >>>> tagging the current trunk as: >>>> https://svn.jboss.org/repos/jbossas/badbuilds/2008_10_20_r79744/ >>>> and I am about to rollback trunk to r79434. >>>> >>>> For every change you want to apply/re-apply you *must* make sure >>>> the testsuite doesn't regress. >>>> >>>> Cheers >>>> /D >>>> _______________________________________________ >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>>> >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development >> > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development > > ------------------------------------------------------------------------ > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development