9:23 a.m.
Removing the server info logging like JVM version is very annoying
as well.
In production most people will run with at least INFO filter
so this information is lost.
I want to know what people actually used, not what they think
they used. :-)
On Wed, 2006-09-20 at 09:07 -0500, Sacha Labourey wrote:
1) As discussed, I don't think I broke anything: the statements
are
still logged in the JBoss log file and I don't think the spec requires
these logging statements to be in the console rather than in the logging
file (never saw these warning on WL console for example)
2) I am surprise if you don't receive the CVS/SVN e-mails on my commits
as I did receive them (see attachement)
> -----Original Message-----
> From: Adrian Brock
> Sent: mercredi, 20. septembre 2006 15:44
> To: jboss-development
> Cc: Sacha Labourey; QA
> Subject: Logging changes in head - and missing commit e-mails
>
> Sacha,
>
> Please discuss changes before making them.
>
> This logging in RARDeployment
>
> log.info("Required license terms exist, view META-INF/ra.xml
> in " + ServerConfigUtil.shortUrlFromServerHome(di.url.toString()));
>
> is a spec requirement!
>
> I don't know what other changes you made since I have no
> notification of any of them via e-mail on the cvs/svn mailing list.
>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxx
> Adrian Brock
> Chief Scientist
> JBoss a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
email message attachment
> -------- Forwarded Message --------
> From: jboss-cvs-commits(a)lists.jboss.org
> Reply-To: jboss-cvs-commits(a)lists.jboss.org
> To: jboss-cvs-commits(a)lists.jboss.org
> Subject: [Jboss-cvs] JBossAS SVN: r56863 - in
>
trunk:aspects/src/main/org/jboss/aop/deploymentconnector/src/main/org/jboss/resource/adapter/quartz/inflowconnector/src/main/org/jboss/resource/deploymentjbossas/jmx-remoting/src/main/org/jboss/mx/remoting/serviceserver/src/main/org/jboss/loggingsystem/src/main/org/jboss/system/server
> Date: Thu, 14 Sep 2006 14:52:38 -0500
>
> Author: sacha.labourey(a)jboss.com
> Date: 2006-09-14 15:52:27 -0400 (Thu, 14 Sep 2006)
> New Revision: 56863
>
> Modified:
> trunk/aspects/src/main/org/jboss/aop/deployment/AspectDeployer.java
>
trunk/connector/src/main/org/jboss/resource/adapter/quartz/inflow/QuartzResourceAdapter.java
> trunk/connector/src/main/org/jboss/resource/deployment/RARDeployment.java
>
trunk/jbossas/jmx-remoting/src/main/org/jboss/mx/remoting/service/JMXConnectorServerService.java
> trunk/server/src/main/org/jboss/logging/Log4jService.java
> trunk/system/src/main/org/jboss/system/server/ServerImpl.java
> trunk/system/src/main/org/jboss/system/server/ServerInfo.java
> Log:
> Reducing verbose logging.
>
> Modified: trunk/aspects/src/main/org/jboss/aop/deployment/AspectDeployer.java
> ===================================================================
> --- trunk/aspects/src/main/org/jboss/aop/deployment/AspectDeployer.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++ trunk/aspects/src/main/org/jboss/aop/deployment/AspectDeployer.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -167,7 +167,7 @@
> AspectXmlLoader.deployXML(docURL, scl);
> Notification msg = new Notification("AOP Deploy", this,
getNextNotificationSequenceNumber());
> sendNotification(msg);
> - log.info("Deployed AOP: " + di.url);
> + log.debug("Deployed AOP: " + di.url);
> }
> catch (Exception ex)
> {
>
> Modified:
trunk/connector/src/main/org/jboss/resource/adapter/quartz/inflow/QuartzResourceAdapter.java
> ===================================================================
> ---
trunk/connector/src/main/org/jboss/resource/adapter/quartz/inflow/QuartzResourceAdapter.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++
trunk/connector/src/main/org/jboss/resource/adapter/quartz/inflow/QuartzResourceAdapter.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -55,7 +55,7 @@
>
> public void start(BootstrapContext ctx) throws ResourceAdapterInternalException
> {
> - log.info("start quartz!!!");
> + log.debug("start quartz!!!");
> // First we must get a reference to a scheduler
> SchedulerFactory sf = new StdSchedulerFactory();
> try
>
> Modified: trunk/connector/src/main/org/jboss/resource/deployment/RARDeployment.java
> ===================================================================
> ---
trunk/connector/src/main/org/jboss/resource/deployment/RARDeployment.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++
trunk/connector/src/main/org/jboss/resource/deployment/RARDeployment.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -113,7 +113,7 @@
> {
> if (cmd.getLicense().getRequired())
> {
> - log.info ("Required license terms exist, view META-INF/ra.xml in
" + ServerConfigUtil.shortUrlFromServerHome(di.url.toString()));
> + log.debug ("Required license terms exist, view META-INF/ra.xml in
" + ServerConfigUtil.shortUrlFromServerHome(di.url.toString()));
> log.debug("License terms full URL: " + di.url);
> }
> resourceAdapter = ResourceAdapterFactory.createResourceAdapter(rdmd);
>
> Modified:
trunk/jbossas/jmx-remoting/src/main/org/jboss/mx/remoting/service/JMXConnectorServerService.java
> ===================================================================
> ---
trunk/jbossas/jmx-remoting/src/main/org/jboss/mx/remoting/service/JMXConnectorServerService.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++
trunk/jbossas/jmx-remoting/src/main/org/jboss/mx/remoting/service/JMXConnectorServerService.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -109,7 +109,7 @@
> connectorServer = JMXConnectorServerFactory.newJMXConnectorServer(url, null,
mbeanServer);
> connectorServer.start();
>
> - log.info("JMX Connector server: " + serviceURL);
> + log.debug("JMX Connector server: " + serviceURL);
> }
>
> public void stop() throws IOException
>
> Modified: trunk/server/src/main/org/jboss/logging/Log4jService.java
> ===================================================================
> --- trunk/server/src/main/org/jboss/logging/Log4jService.java 2006-09-14 19:25:31
UTC (rev 56862)
> +++ trunk/server/src/main/org/jboss/logging/Log4jService.java 2006-09-14 19:52:27
UTC (rev 56863)
> @@ -596,7 +596,7 @@
>
> private void reconfigure(final URLConnection conn)
> {
> - log.info("Configuring from URL: " + configURL);
> + log.debug("Configuring from URL: " + configURL);
>
> boolean xml = false;
> boolean trace = log.isTraceEnabled();
>
> Modified: trunk/system/src/main/org/jboss/system/server/ServerImpl.java
> ===================================================================
> --- trunk/system/src/main/org/jboss/system/server/ServerImpl.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++ trunk/system/src/main/org/jboss/system/server/ServerImpl.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -218,18 +218,18 @@
> }
>
> // Log the basic configuration elements
> - log.info("Home Dir: " + config.getHomeDir());
> + log.debug("Home Dir: " + config.getHomeDir());
> log.info("Home URL: " + config.getHomeURL());
> log.debug("Library URL: " + config.getLibraryURL());
> - log.info("Patch URL: " + config.getPatchURL());
> + log.debug("Patch URL: " + config.getPatchURL());
> log.info("Server Name: " + config.getServerName());
> - log.info("Server Home Dir: " + config.getServerHomeDir());
> - log.info("Server Home URL: " + config.getServerHomeURL());
> + log.debug("Server Home Dir: " + config.getServerHomeDir());
> + log.debug("Server Home URL: " + config.getServerHomeURL());
> log.debug("Server Data Dir: " + config.getServerDataDir());
> - log.info("Server Temp Dir: " + config.getServerTempDir());
> + log.debug("Server Temp Dir: " + config.getServerTempDir());
> log.debug("Server Config URL: " + config.getServerConfigURL());
> log.debug("Server Library URL: " + config.getServerLibraryURL());
> - log.info("Root Deployment Filename: " +
config.getRootDeploymentFilename());
> + log.debug("Root Deployment Filename: " +
config.getRootDeploymentFilename());
> }
>
> /**
>
> Modified: trunk/system/src/main/org/jboss/system/server/ServerInfo.java
> ===================================================================
> --- trunk/system/src/main/org/jboss/system/server/ServerInfo.java 2006-09-14
19:25:31 UTC (rev 56862)
> +++ trunk/system/src/main/org/jboss/system/server/ServerInfo.java 2006-09-14
19:52:27 UTC (rev 56863)
> @@ -107,7 +107,7 @@
> {
> this.server = server;
> // Dump out basic JVM & OS info as INFO priority msgs
> - log.info("Java version: " +
> + log.debug("Java version: " +
> System.getProperty("java.version") + "," +
> System.getProperty("java.vendor"));
>
>
> _______________________________________________
> jboss-cvs-commits mailing list
> jboss-cvs-commits(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-cvs-commits
>
--
xxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxx
9:42 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
Removing the server info logging like JVM version is very
annoying as well.
Not sure I agree. Look at the code:
log.info("Java version: " +
System.getProperty("java.version") + "," +
System.getProperty("java.vendor"));
log.info("Java VM: " +
System.getProperty("java.vm.name") + " " +
System.getProperty("java.vm.version") + "," +
System.getProperty("java.vm.vendor"));
I've only changed the first one, not the second one. Let me know if, with
any JVM you tried, the second output (i.e. java.vm.* vs. Java.*) doesn't
display the information you need. They are just pure overlap IMO. On my
laptop for example:
java.version: 1.5.0_06
java.vendor: Sun Microsystems Inc.
java.vm.name: Java HotSpot(TM) Client VM
java.vm.version: 1.5.0_06-b05
java.vm.vendor: Sun Microsystems Inc.
I've kept the logging of the second block at the INFO level.
In production most people will run with at least INFO filter
so this information is lost.
See above
I want to know what people actually used, not what they think
they used. :-)
I agree, see above.
9:57 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
On Wed, 2006-09-20 at 16:42 +0200, Sacha Labourey wrote:
They are just pure overlap IMO. On my
laptop for example:
java.version: 1.5.0_06
java.vendor: Sun Microsystems Inc.
java.vm.name: Java HotSpot(TM) Client VM
java.vm.version: 1.5.0_06-b05
java.vm.vendor: Sun Microsystems Inc.
Ok, then it is minor point, at least for the Sun JDK.
But...
1) What about other JDKs?
2) When Sun open source hotspot,
java.vendor (JDK) != java.vm.vendor (Hotspot)
--
xxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxx
10:12 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
Show me an example.
-----Original Message-----
From: Adrian Brock
Sent: mercredi, 20. septembre 2006 16:58
To: EXT: Sacha ML
Cc: jboss-development; QA
Subject: RE: Logging changes in head - and missing commit e-mails
On Wed, 2006-09-20 at 16:42 +0200, Sacha Labourey wrote:
> They are just pure overlap IMO. On my
> laptop for example:
>
> java.version: 1.5.0_06
> java.vendor: Sun Microsystems Inc.
>
> java.vm.name: Java HotSpot(TM) Client VM
> java.vm.version: 1.5.0_06-b05
> java.vm.vendor: Sun Microsystems Inc.
Ok, then it is minor point, at least for the Sun JDK.
But...
1) What about other JDKs?
2) When Sun open source hotspot,
java.vendor (JDK) != java.vm.vendor (Hotspot)
--
xxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxx
10:27 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
On Wed, 2006-09-20 at 17:12 +0200, Sacha Labourey wrote:
Show me an example.
Of open source hotspot? :-)
You made the change, you should justify it.
I can't prove a negative.
My original point is people changing things without discussing
it first.
Look at how much hassle your jbossmq-destinations.xml
change made. I still don't believe that works properly.
> -----Original Message-----
> From: Adrian Brock
> Sent: mercredi, 20. septembre 2006 16:58
> To: EXT: Sacha ML
> Cc: jboss-development; QA
> Subject: RE: Logging changes in head - and missing commit e-mails
>
> On Wed, 2006-09-20 at 16:42 +0200, Sacha Labourey wrote:
> > They are just pure overlap IMO. On my
> > laptop for example:
> >
> > java.version: 1.5.0_06
> > java.vendor: Sun Microsystems Inc.
> >
> > java.vm.name: Java HotSpot(TM) Client VM
> > java.vm.version: 1.5.0_06-b05
> > java.vm.vendor: Sun Microsystems Inc.
>
> Ok, then it is minor point, at least for the Sun JDK.
>
> But...
>
> 1) What about other JDKs?
>
> 2) When Sun open source hotspot,
> java.vendor (JDK) != java.vm.vendor (Hotspot)
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxx
> Adrian Brock
> Chief Scientist
> JBoss a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
--
xxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxx
10:41 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
> Show me an example.
Of open source hotspot? :-)
You made the change, you should justify it.
I can't prove a negative.
LOL, I just thing you are funny trying to hunt me on any change I make :)
(as basic as the logging statements...).
The start of JBoss displays so much crap that any user is horrified and
cannot distinguish the usefull from the non-usefull stuff. Logging that kind
of thing (java.vendor + java.vm.vendor) is just such an example of
over-engineering.
My original point is people changing things without
discussing it first.
Yeah, so let's start discussing all of the crap being logged on HEAD today,
starting with clustering and tomcat.
10:58 a.m.
New subject: [JBoss-dev] RE: Logging changes in head - and missing commit e-mails
On Wed, 2006-09-20 at 17:41 +0200, Sacha Labourey wrote:
Yeah, so let's start discussing all of the crap being logged on
HEAD today,
starting with clustering and tomcat.
You mean the broken commons-logging mapping.
It should be:
DEBUG -> TRACE
INFO -> DEBUG
--
xxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxx
7142
days inactive
7142
days old
jboss-development@lists.jboss.org
6 comments
2 participants
participants (2)
-
Adrian Brock -
Sacha Labourey