With a quick search I've found org.dom4j usage in the A) jmx module (DescriptorSupport, JBossXMBean10, XMLMetadata, XMBean) B) deployment module (DeploymentMetadata, DeploymentManagerImpl) C) console module (XMLToHTMLTreeBuilder) D) build (VersionRelease) - not realy an issue Should I switch all to use org.jboss.dom4j and bundle with jboss-jmx.jar? Or Switch the jmx module, bundle with jboss-jmx.jar and, include the original dom4j.jar in server/lib for the others (including end-user code that depends on dom4j). But then, our jarjar'ed version would have to be in a different place in the repository (can't have 2 versions of the same thing), like repository.jboss.com/jboss/dom4j/1.6.1.jarjar > -----Original Message----- > From: jboss-development-bounces(a)lists.jboss.org > [mailto:jboss-development-bounces@lists.jboss.org] On Behalf > Of Dimitris Andreadis > Sent: Tuesday, September 19, 2006 3:00 PM > To: Steve Ebersole; Emmanuel Bernard; Scott M Stark > Cc: JBoss.org development list > Subject: RE: [JBoss-dev] Re: Library dependencies/updates for > jboss-4.0.5.GA > > What about Hibernate usage of dom4j? > > If I make the jmx/system code use the jarjard version, > hibernate will need to include it seperately. > > > -----Original Message----- > > From: jboss-development-bounces(a)lists.jboss.org > > [mailto:jboss-development-bounces@lists.jboss.org] On > Behalf Of Scott > > M Stark > > Sent: Monday, September 18, 2006 8:02 PM > > To: JBoss.org development list > > Subject: Re: [JBoss-dev] Re: Library dependencies/updates for > > jboss-4.0.5.GA > > > > I have put the jarjard dom4j jar into the repository here: > > http://repository.jboss.com/dom4j/1.6.1.jarjar > > > > It contains the dom4j-jarjar.jar (which uses an > org.jboss.dom4j root > > package namespace), and the jarjar build script: > > <project name="Jarjar dom4j" default="patchdom4j"> > > <!-- > > A jarjar ant build script to create the jarjard dom4j jar. > > --> > > <target name="patchdom4j"> > > <taskdef name="jarjar" > > classname="com.tonicsystems.jarjar.JarJarTask" > > classpath="dist/jarjar-0.7.jar"/> > > <mkdir dir="output" /> > > <jarjar jarfile="output/dom4j-jarjar.jar"> > > <manifest> > > <attribute name="Created-by" > > value="${java.vm.version} ${java.vm.vendor}"/> > > <attribute name="Specification-Title" > > value="Dom4j > > JarJar(org.jboss.dom4j)"/> > > <attribute name="Specification-Version" > > value="1.6.1"/> > > <attribute name="Specification-Vendor" > > value="http://dom4j.org/"/> > > <attribute name="Implementation-Title" > > value="JarJar > > Dom4j"/> > > <attribute name="Implementation-URL" > > value="http://repository.jboss.com/dom4j/1.6.1.jarjar"/> > > <attribute name="Implementation-Version" > > value="1.6.1.jarjar"/> > > <attribute name="Implementation-Vendor" > > value="JBoss, > > a division of Red Hat"/> > > <attribute name="Implementation-Vendor-Id" > > value="http://www.jboss.org"/> > > </manifest> > > <zipfileset src="dom4j.jar"/> > > <rule pattern="org.dom4j.**" > result="org.jboss.dom4j.@1"/> > > <zap pattern="org.dom4j.jaxb.**"/> > > <zap pattern="org.dom4j.swing.**"/> > > <zap pattern="org.dom4j.xpath.**"/> > > </jarjar> > > </target> > > </project> > > > > All that is left is to update all the bootstrap modules which use > > dom4j > > (jmx/j2se/system/system-jmx) to use the new namespace. The > dom4j jars > > could be embedded into one of these module output jars as an > > implementation detail to reduce the number of bootstrap jars if > > desired. > > > > Scott M Stark wrote: > > > It would be kept in the server/default/lib for app > > compatibility. It > > > would just be embedded in the core jmx/system layer as an > > impl detail > > > and removed from the server bootstrap classpath. > > > > > > Emmanuel Bernard wrote: > > >> Keep Steve in the loop since Hibernate use dom4j > > >> > > > > > > > _______________________________________________ > > jboss-development mailing list > > jboss-development(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/jboss-development > > > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

What api are you talking about being broken? The dom4j uses will be supported by deploying dom4j in the server lib. Neither the deployment or console module uses need to be changed because these are not in the server bootstrap classpath. Its a fair question as to whether jarjar is worthwhile vs converting the few uses to use the bundled jdk apis. Adrian Brock wrote: > The only reason JBossMX uses dom4j is for the XMBean. > > If you switch to the jarjared version then this api > is broken for existing users. > > If you are going to change the api to remove the dependency, > I'd rather see it changed to org.w3c.dom.* > > On Tue, 2006-09-19 at 08:43 -0500, Dimitris Andreadis wrote: > >> With a quick search I've found org.dom4j usage in the >> >> A) jmx module (DescriptorSupport, JBossXMBean10, XMLMetadata, XMBean) >> B) deployment module (DeploymentMetadata, DeploymentManagerImpl) >> C) console module (XMLToHTMLTreeBuilder) >> >> D) build (VersionRelease) - not realy an issue >> >> Should I switch all to use org.jboss.dom4j and bundle with >> jboss-jmx.jar? >> >> Or >> >> Switch the jmx module, bundle with jboss-jmx.jar and, include the >> original dom4j.jar in server/lib for the others (including end-user code >> that depends on dom4j). >> >> But then, our jarjar'ed version would have to be in a different place in >> the repository (can't have 2 versions of the same thing), like >> repository.jboss.com/jboss/dom4j/1.6.1.jarjar >> >>

Ok, but there are zero uses of that ctor in the codebase.

Its going to be broken one way or another if you jarjar or revert to the jaxp apis.

Adrian Brock wrote: > org.dom4j.Element element = ... > XMBean mbean = new XMBean(object, element, version); > server.registerMBean(mbean); > > Won't work if it is org.jboss.dom4j.Element > >