RE: [jboss-dev] Re: Commons-logging upgrade
by Dimitris Andreadis
I had a quick look at cvs.forge.jboss.com:/cvsroot/jboss -
apache/commons-logging.
If we are going to patch the latest v1.1, I'd rather let Scott do it,
since he has been maintaining the patched library from the start.
On the other hand, wouldn't the right thing to do be for users to have
to include commons-logging.jar + log4j.jar, even if that means older
deployments might be slightly broken (but easy to fix)?
> -----Original Message-----
> From: Brian Stansberry
> Sent: Wednesday, January 24, 2007 7:32 PM
> To: Dimitris Andreadis; Scott M Stark
> Cc: 'JBoss.org development list'
> Subject: RE: [jboss-dev] Re: Commons-logging upgrade
>
> So, 2 issues:
>
> 1) Do we remove org.apache.commons.logging from FilteredPackages?
>
> I've attached 2 files showing what happens if you do this in
> 4.0.5 and 4.0.2 and then deploy a war with
> commons-logging.jar included. The 4.0.2 one shows a
> JaccContextValve failure that was likely the thing that led
> to filtering the packages.
>
> In 4.2, this works fine.
>
> IMHO, if a quick perusal of the attached files by you and
> Scott isn't enough to decide to remove the filtering of JCL
> packages, we should leave them filtered. That's a
> conservative approach, which is fine when we have lots of
> other things to worry about.
>
> 2) Patching JCL 1.1 to do late binding of log4j. That's
> useful, if for nothing else to support consistent behavior
> from 4.0.x to 4.2.0 for wars that bundle log4j but not
> commons-logging.jar. Definitely needed if we decide to keep
> the jcl package filtering. The JIRA to do the patch was
> assigned by you to you, so I guess you volunteered ;)
>
> You're my boss, so feel free to assign it to me. :-) But I
> won't touch it until the EJB3 stuff and shared sessions are done.
>
> Dimitris Andreadis wrote:
> > Right, so who will volunteer to get this sorted out ? :)
> >
> >> -----Original Message-----
> >> From: jboss-development-bounces(a)lists.jboss.org
> >> [mailto:jboss-development-bounces@lists.jboss.org] On
> Behalf Of Scott
> >> M Stark Sent: Tuesday, January 23, 2007 1:31 AM
> >> To: JBoss.org development list
> >> Subject: Re: [jboss-dev] Re: Commons-logging upgrade
> >>
> >> Its required in general to avoid java ee classes from
> being visible.
> >> Specificially for the jcl classes, it should not be required.
> >> I'm hesitant to say it can be dropped though since the
> problem is a
> >> function of the runtime class loader hierarchy that shows
> up for the
> >> various component creation/initial use patterns. I guess I need to
> >> reproduce the original issue to understand why its not
> happening now.
> >>
> >> Brian Stansberry wrote:
> >>> jboss-development-bounces(a)lists.jboss.org wrote: ...
> >>>
> >>> Yes. I didn't mean to imply the late binding patch no longer had
> >>> value; just that allowing the loading of JCL classes from the war
> >>> removes a large category of cases where it is needed. I
> also wanted
> >>> to hijack the thread a bit to get into whether the
> >> FilteredPackages was still needed.
> >>> :-)
> >>>
> >>
> >> _______________________________________________
> >> jboss-development mailing list
> >> jboss-development(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/jboss-development
>
>
>
> Brian Stansberry
> Lead, AS Clustering
> JBoss, a division of Red Hat
> Ph: 510-396-3864
> skype: bstansberry
19 years, 2 months
RE: Plan for JBossAS 4.2.0.CR1 - Your Help is Needed
by Dimitris Andreadis
I have been searching for this message, thanks!
> -----Original Message-----
> From: Adrian Brock
> Sent: Wednesday, January 24, 2007 7:16 PM
> To: Dimitris Andreadis
> Cc: JBoss.org development list; The Core; jboss-as(a)redhat.com
> Subject: Re: Plan for JBossAS 4.2.0.CR1 - Your Help is Needed
>
> Is somebody looking at getting the JBoss Transactions
> integration configured properly like I explained on a previous e-mail?
>
> http://lists.jboss.org/pipermail/jboss-development/2007-Januar
> y/004776.html
>
> On Wed, 2007-01-24 at 10:15 -0600, Dimitris Andreadis wrote:
> > Hi folks,
> >
> > We are shooting for Feb/26th for JBossAS 4.2.0.CR1, which
> is only 4.5
> > weeks away. As a consequence:
> >
> > 1) We must finish with all development/bug fixing tasks by Feb/5th.
> > Anything not done until then will be deferred.
> >
> > 2) EJB3 team has an additional week to work (until Feb/12th) and a
> > couple more days to finish any integration tasks.
> >
> > 3) If you are not doing features development, please help
> *now* fixing
> > the testsuites. We are looking a lot better (93%) than last week
> > (~70%) but there is still way to go.
> >
> >
> http://cruisecontrol.jboss.com/cc/buildresults/jboss-4.2-testsuite-1.5
> >
> > There a few things broken mainly due to
> >
> > tomcat->jboss-web transition,
> > jrmp->unified invoker changes
> > jbossTM->jbossTS(arjuna) switch
> >
> > Most failing tests are in the following categories:
> >
> > org.jboss.test.cluster.test
> > org.jboss.test.cmp2.audit.test
> > org.jboss.test.cmp2.simple
> > org.jboss.test.compatibility.test
> > org.jboss.test.jacc.test
> > org.jboss.test.jca.test
> > org.jboss.test.testbeancluster.test
> > org.jboss.test.tm.test
> > org.jboss.test.txiiop.test
> > org.jboss.test.web.test
> > org.jboss.test.webservice.*
> > ...
> >
> > 4) We want to pass as much (or all?) of TCK1.4 for 4.2.0.CR1 :) I
> > wanted to delay this until we get most of the jboss testsuites
> > passing, but we can't delay this any longer.
> >
> > JBoss 4.2 is a priority, so whether it is working on JIRA tasks,
> > testsuites, fixes or TCK stuff, there is plenty of work to do for
> > everyone, so your help is very much (and urgently) needed.
> >
> > If you see issues with this schedule, let me know.
> >
> > We'll probably create and assign JIRA tasks for the testsuites/TCK
> > fixes (we only recently managed to get some good teststuite
> runs), but
> > please don't wait for that and be proactive.
> >
> > Thanks
> > /Dimitris
> >
> >
> >
> >
> > --
> > xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> > Dimitris Andreadis
> > JBoss AS, Project Lead
> > JBoss, a Division of Red Hat
> > xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Adrian Brock
> Chief Scientist
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
19 years, 2 months
RE: [jboss-dev] Re: Commons-logging upgrade
by Brian Stansberry
So, 2 issues:
1) Do we remove org.apache.commons.logging from FilteredPackages?
I've attached 2 files showing what happens if you do this in 4.0.5 and
4.0.2 and then deploy a war with commons-logging.jar included. The
4.0.2 one shows a JaccContextValve failure that was likely the thing
that led to filtering the packages.
In 4.2, this works fine.
IMHO, if a quick perusal of the attached files by you and Scott isn't
enough to decide to remove the filtering of JCL packages, we should
leave them filtered. That's a conservative approach, which is fine when
we have lots of other things to worry about.
2) Patching JCL 1.1 to do late binding of log4j. That's useful, if for
nothing else to support consistent behavior from 4.0.x to 4.2.0 for wars
that bundle log4j but not commons-logging.jar. Definitely needed if we
decide to keep the jcl package filtering. The JIRA to do the patch was
assigned by you to you, so I guess you volunteered ;)
You're my boss, so feel free to assign it to me. :-) But I won't touch
it until the EJB3 stuff and shared sessions are done.
Dimitris Andreadis wrote:
> Right, so who will volunteer to get this sorted out ? :)
>
>> -----Original Message-----
>> From: jboss-development-bounces(a)lists.jboss.org
>> [mailto:jboss-development-bounces@lists.jboss.org] On Behalf Of
>> Scott M Stark Sent: Tuesday, January 23, 2007 1:31 AM
>> To: JBoss.org development list
>> Subject: Re: [jboss-dev] Re: Commons-logging upgrade
>>
>> Its required in general to avoid java ee classes from being visible.
>> Specificially for the jcl classes, it should not be required.
>> I'm hesitant to say it can be dropped though since the problem is a
>> function of the runtime class loader hierarchy that shows up for the
>> various component creation/initial use patterns. I guess I need to
>> reproduce the original issue to understand why its not happening now.
>>
>> Brian Stansberry wrote:
>>> jboss-development-bounces(a)lists.jboss.org wrote: ...
>>>
>>> Yes. I didn't mean to imply the late binding patch no longer had
>>> value; just that allowing the loading of JCL classes from the war
>>> removes a large category of cases where it is needed. I also wanted
>>> to hijack the thread a bit to get into whether the
>> FilteredPackages was still needed.
>>> :-)
>>>
>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
Ph: 510-396-3864
skype: bstansberry
19 years, 2 months
