Re: [jboss-dev] changes in parsing with xb

The change is supposed to be temporary, since the real problem is that our schemas are flat-out wrong. Once these are corrected, the setting will become unnecessary. However, we could change the default if it is still causing issues. Jaikiran Pai wrote: > Any script/tool which bypasses the run.bat/run.conf is likely to run > into problems, unless it sets this property explicitly. So yes, > setting it to "allow unordered sequence" by default makes sense (till > all the xmls are fixed). > > P.S: Isn't JBoss Tools affected by this change? I guess, it triggers > the AS without the use of the run.conf/run.bat isn't it? > > -Jaikiran > Dimitris Andreadis wrote: >> Since this setting is likely to cause problems to user deployments, >> as well, should the default be to allow undordered sequences? >> >> I mean not having to set this through the build scripts, or otherwise. >> >> Rather, enable strictordering if only you want to. >> >> Jaikiran Pai wrote: >>> I have now added this property to the server-config in >>> org.jboss.test:jboss-test project >>> https://svn.jboss.org/repos/jbossas/projects/test/trunk/src/main/resource... >>> >>> >>> This will prevent server startup issues in testsuites of projects >>> (like EJB3) which depend on org.jboss.test:jboss-test. Version >>> 1.1.5-SNAPSHOT of org.jboss.test:jboss-test has been deployed in >>> repo with this change. >>> >>> regards, >>> -Jaikiran >>> >>> >>> >>> Jason T. Greene wrote: >>>> Ah yeah, noticed this as well. I updated all server configs to >>>> include this for now. So far it looks like this resolves the issue. >>>> >>>> Shelly McGowan wrote: >>>>> >>>>> Jason, >>>>> >>>>> When starting the minimal server from the command line; i.e., >>>>> >>>>> ./run.sh -c minimal >>>>> >>>>> -Dxb.builder.useUnorderedSequence=true is passed in via: >>>>> >>>>> JAVA_OPTS="$JAVA_OPTS -Dxb.builder.useUnorderedSequence=true" >>>>> >>>>> But this property is not passed in when starting the test configs >>>>> >>>>> >>>>> Shelly >>>>> >>>>> >>>>> ----- Original Message ----- >>>>> From: "Jason T. Greene" <jason.greene(a)redhat.com&gt; >>>>> To: "JBoss.org development list" <jboss-development(a)lists.jboss.org&gt; >>>>> Sent: Tuesday, April 7, 2009 2:15:10 PM GMT -05:00 US/Canada Eastern >>>>> Subject: Re: [jboss-dev] changes in parsing with xb >>>>> >>>>> >>>>> Anyone else see this? It is working for me >>>>> >>>>> Carlo de Wolf wrote: >>>>>> Testsuite shows a 100% regression as minimal fails to boot up. >>>>>> >>>>>> Failed to boot JBoss: >>>>>> org.jboss.xb.binding.JBossXBException: Failed to parse source: >>>>>> file:/home/hudson/.hudson/jobs/JBoss-AS-5.x-TestSuite-sun15/workspace/Branch_5_x/build/output/jboss-5.1.0.CR1/server/minimal/conf/bootstrap/deployers.xml@46,56 >>>>>> >>>>>> Caused by: org.jboss.xb.binding.JBossXBRuntimeException: >>>>>> {urn:jboss:bean-deployer:2.0}incallback cannot appear in this >>>>>> position. Expected content of {urn:jboss:bean-deployer:2.0}bean >>>>>> is sequence: {urn:jboss:bean-deployer:2.0}alias* >>>>>> {urn:jboss:bean-deployer:2.0}related-class* >>>>>> {urn:jboss:bean-deployer:2.0}annotation* >>>>>> {urn:jboss:bean-deployer:2.0}classloader? >>>>>> {urn:jboss:bean-deployer:2.0}constructor? >>>>>> {urn:jboss:bean-deployer:2.0}property* >>>>>> {urn:jboss:bean-deployer:2.0}create? >>>>>> {urn:jboss:bean-deployer:2.0}start? >>>>>> {urn:jboss:bean-deployer:2.0}stop? >>>>>> {urn:jboss:bean-deployer:2.0}destroy? >>>>>> {urn:jboss:bean-deployer:2.0}depends* >>>>>> {urn:jboss:bean-deployer:2.0}demand* >>>>>> {urn:jboss:bean-deployer:2.0}supply* >>>>>> {urn:jboss:bean-deployer:2.0}install* >>>>>> {urn:jboss:bean-deployer:2.0}uninstall* >>>>>> {urn:jboss:bean-deployer:2.0}incallback* >>>>>> {urn:jboss:bean-deployer:2.0}uncallback* >>>>>> >>>>>> I'm inclined to do a rollback, because anything coming in *must* >>>>>> be backwards compatible. >>>>>> A log.warn instead of a failure would have been better. >>>>>> >>>>>> I'll give it 24 hours to be fixed. >>>>>> >>>>>> Your friendly BOFH, >>>>>> >>>>>> Carlo >>>>>> >>>>>> Alexey Loubyansky wrote: >>>>>>> There have been many fixes in the last two beta releases of XB >>>>>>> that will affect AS and other users. >>>>>>> Most noticeable changes/fixes are related to internal navigation >>>>>>> across schema structures during XML parsing. In simple words, XB >>>>>>> is now (much) more sensitive to validation issues (incorrect >>>>>>> element order, etc). >>>>>>> Some files that could be parsed before, now (with default >>>>>>> settings) won't. WRT AS it would be e.g. vfs, aop xml etc. >>>>>>> >>>>>>> To workaround this, you can set system property >>>>>>> xb.builder.useUnorderedSequence to true. This will make the >>>>>>> order in which elements from a sequence appear in xml not >>>>>>> important. >>>>>>> Alternatively, you can call >>>>>>> JBossXBBuilder.setUseUnorderedSequence(boolean value) or use >>>>>>> annotation >>>>>>> @JBossXmlModelGroup(kind=JBossXmlConstants.MODEL_GROUP_UNORDERED_SEQUENCE) >>>>>>> to bind classes to unordered sequences. >>>>>>> >>>>>>> But this has to remain a workaround, not the default. There has >>>>>>> to be a good reason to use unordered sequences. Fix your XML and >>>>>>> binding now. >>>>>>> >>>>>>> The latest XB has not been integrated into the AS yet (although, >>>>>>> I ran some tests from the AS testsuite locally) due to >>>>>>> dependency on changes in VFS and deployers: >>>>>>> https://jira.jboss.org/jira/browse/JBVFS-99 >>>>>>> https://jira.jboss.org/jira/browse/JBDEPLOY-173 >>>>>>> >>>>>>> The latest metadata release (1.0.0.CR17) requires at least XB >>>>>>> 2.0.1.Beta3. >>>>>>> >>>>>>> If you are using XB, please, try the latest beta. >>>>>>> >>>>>>> Here are release notes for XB 2.0.1.Beta3 >>>>>>> https://jira.jboss.org/jira/secure/ReleaseNote.jspa?version=12313320&... >>>>>>> >>>>>>> >>>>>>> and XB 2.0.1.Beta2 >>>>>>> https://jira.jboss.org/jira/secure/ReleaseNote.jspa?version=12313217&... >>>>>>> >>>>>>> _______________________________________________ >>>>>>> jboss-development mailing list >>>>>>> jboss-development(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>>>>> _______________________________________________ >>>>>> jboss-development mailing list >>>>>> jboss-development(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>>>> >>>>> >>>> >>>> >>> >>> _______________________________________________ >>> jboss-development mailing list >>> jboss-development(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jboss-development >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development