Sorry for the regression.
It seems to me null would be an invalid argument. The template should
not pass in null value. I'll look into this.
Ales Justin wrote:
This is irrelevant error,
we should look what's the real cause before.
Since I doubt server shutdown always in the last few runs -
when the failures occurred.
Alex, what's the proper fix for NPE, this?
@Deprecated
public void setTrackConnectionByTransaction(Boolean
trackConnectionByTransaction)
{
if (trackConnectionByTransaction == null)
return;
if(getLocalTransactions() && !trackConnectionByTransaction)
throw new IllegalStateException("In case of local transactions
track-connection-by-tx must always be true");
setInterleaving(!trackConnectionByTransaction);
}
> The run last night failed because the server was
> shutdown before the test finished, see around 03:17:26
>
>
http://hudson.jboss.org/hudson/job/JBoss-AS-5.0.x-TestSuite-sun15/849/art...
>
>
> It's currently failing for me, because of an NPE,
> which looks related to Alex's change:
>
> Caused by: java.lang.NullPointerException
> at
>
org.jboss.resource.metadata.mcf.ManagedConnectionFactoryDeploymentMetaData.setTrackConnectionByTransaction(ManagedConnectionFactoryDeploymentMetaData.java:5
>
> 29)
> at
>
org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:59)
>
> at
>
org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:150)
>
> at
> org.jboss.beans.info.plugins.DefaultPropertyInfo.set(DefaultPropertyInfo.java:143)
>
> at
>
org.jboss.managed.plugins.factory.AbstractInstanceClassFactory.setValue(AbstractInstanceClassFactory.java:303)
>
> at
>
org.jboss.managed.plugins.factory.AbstractInstanceClassFactory.setValue(AbstractInstanceClassFactory.java:256)
>
> at
>
org.jboss.managed.plugins.WritethroughManagedPropertyImpl.setValue(WritethroughManagedPropertyImpl.java:109)
>
> at
>
org.jboss.resource.deployers.management.DsDataSourceTemplate.writeTemplate(DsDataSourceTemplate.java:154)
>
> at
>
org.jboss.resource.deployers.management.DsDataSourceTemplate.applyTemplate(DsDataSourceTemplate.java:70)
>
> at
>
org.jboss.profileservice.management.ManagementViewImpl.applyTemplate(ManagementViewImpl.java:673)
>
>
>
> -------- Forwarded Message --------
>
> They work for me locally, so I don't see how I can look for what's wrong
>
> test:
> [delete] Deleting: C:\DOCUME~1\Ales\LOCALS~1\Temp\test.log
> [junit] Running
> org.jboss.test.profileservice.test.DeployUnitTestCase
> [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed:
> 23,953 sec
> [junit] Running
> org.jboss.test.profileservice.test.JmsDestinationUnitTestCase
> [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 8,422
> sec
> [junit] Running
> org.jboss.test.profileservice.test.ProfileServiceUnitTestCase
> [junit] Tests run: 22, Failures: 0, Errors: 0, Time elapsed:
> 11,875 sec
>
> BUILD SUCCESSFUL
>
> The cause of this failures below is also weird.
> Since it states there is testEjb3xDeployment failure
>
>
vfszip:/qa/services/hudson/hudson_workspace/workspace/JBoss-AS-5.0.x-TestSuite-sun15/trunk/build/output/jboss-5.0.0.CR2/server/profileservice/deploy/testEjb3xDeployment.jar
> -> java.util.zip.ZipException: error in opening zip file
>
> But I don't see this test failing among failures.
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development