There was a prior discussion on this thread regarding excessive logging in AS 4.2.3 and 5. RE: http://lists.jboss.org/pipermail/jboss-development/2008-November/013043.html Even though Brian provided a configurable option with JBAS-6205, there was no change to the default from DEBUG to INFO at the time of AS 5.0.0.GA and now there are FINE messages logged as well. Are there plans to change the default logging levels for the AS 5.1 release?

And, if so, I'd like to address JBASM-25 which then requires a new release of jboss-server-manager. Shelly _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

Comments inline. On 03/16/2009 03:46 PM, Brian Stansberry wrote: > Shelly McGowan wrote: >> >> There was a prior discussion on this thread regarding excessive >> logging in AS 4.2.3 and 5. >> >> Even though Brian provided a configurable option with JBAS-6205, >> there was no change to the default from DEBUG to INFO at the time of >> AS 5.0.0.GA and now there are FINE messages logged as well. FINE is equivalent to DEBUG. (No, this doesn't add anything to the discussion, just wanted to make sure everyone knows :) >> Are there plans to change the default logging levels for the AS 5.1 >> release? > > I've opened two JIRAs related to this: > > https://jira.jboss.org/jira/browse/JBAS-6629 > https://jira.jboss.org/jira/browse/JBAS-6630 > > The first is to use the system property to control the org.jboss > category level as well as the server.log threshold; the second is to > change to INFO. Two disadvantages to setting the threshold on the appender, as opposed to on the logger (aka category): 1. It makes it impossible to log anything more detailed than that to the log (if you want, say, INFO everywhere but TRACE on just one or two loggers). 2. It defeats per-logger level checks. (Though this is the point where Adrian would jump in and say there shouldn't be any code doing per-logger level checks for anything less than TRACE, because such code shouldn't exist anywhere that gets hit more often than "rarely"). Also, why control just the org.jboss logger? I'd say, have the property just set the level on the root logger instead.

- DML _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

On 03/16/2009 05:42 PM, Brian Stansberry wrote: > David M. Lloyd wrote: >> Also, why control just the org.jboss logger? I'd say, have the >> property just set the level on the root logger instead. > > Fine with me; Darran Lofthouse had complained about the need to > disable the threshold as an extra step in getting logs for support. > Only downsides I see to removing the threshold and adding a priority > to the root logger are: > > 1) behavior change from 5.0.1 (but JBAS-6629/30 are as well, and your > stuff is also a 5.1 change in how logging works, so now seems like the > time.) > > 2) Users have to add a category to get their stuff at finer level vs > just removing the threshold. Which is just another way of saying its a > behavior change. ;) A middle-ground idea might be to have the root logger at INFO always, use the property for "org.jboss" (and maybe selected other loggers?), still leaving off the file appender threshold (though console probably ought to keep at INFO). This way, if someone *wants* e.g. a trace log for one category, they only make one change. If they globally want DEBUG, it's only one change.

- DML _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

On 03/17/2009 07:05 AM, Brian Stansberry wrote: > I don't get it. If you use a property for the root and want to expose > a category at TRACE, you add the category at TRACE -- one change. And > if you want global DEBUG you set the property or replace it with > DEBUG. One change. I thought I had some idea about why this would be better, but I honestly don't remember what it is anymore.

FYI, changes discussed below are done on Branch_5_x. By default logging is now limited to INFO. To get finer logging of a particularly category, add the category to jboss-log4j.xml with the desire level. To change the overall default, set the jboss.server.log.threshold system property at startup, e.g. ./run.sh -Djboss.server.log.threshold=DEBUG. The jboss-server-manager library that launches AS instances in the testsuite sets that property automatically, so server.log files in testsuite runs will remain at DEBUG. (Thanks, Shelly.) AS trunk still logs at DEBUG by default; I'll advise when that has been changed. Brian Stansberry wrote: > David M. Lloyd wrote: >> Comments inline. >> >> On 03/16/2009 03:46 PM, Brian Stansberry wrote: >>> Shelly McGowan wrote: >>>> >>>> There was a prior discussion on this thread regarding excessive >>>> logging in AS 4.2.3 and 5. >>>> >>>> Even though Brian provided a configurable option with JBAS-6205, >>>> there was no change to the default from DEBUG to INFO at the time >>>> of AS 5.0.0.GA and now there are FINE messages logged as well. >> >> FINE is equivalent to DEBUG. (No, this doesn't add anything to the >> discussion, just wanted to make sure everyone knows :) >> >>>> Are there plans to change the default logging levels for the AS 5.1 >>>> release? >>> >>> I've opened two JIRAs related to this: >>> >>> https://jira.jboss.org/jira/browse/JBAS-6629 >>> https://jira.jboss.org/jira/browse/JBAS-6630 >>> >>> The first is to use the system property to control the org.jboss >>> category level as well as the server.log threshold; the second is to >>> change to INFO. >> >> Two disadvantages to setting the threshold on the appender, as >> opposed to on the logger (aka category): >> >> 1. It makes it impossible to log anything more detailed than that to >> the log (if you want, say, INFO everywhere but TRACE on just one or >> two loggers). >> >> 2. It defeats per-logger level checks. (Though this is the point >> where Adrian would jump in and say there shouldn't be any code doing >> per-logger level checks for anything less than TRACE, because such >> code shouldn't exist anywhere that gets hit more often than "rarely"). >> >> Also, why control just the org.jboss logger? I'd say, have the >> property just set the level on the root logger instead. >> > > Fine with me; Darran Lofthouse had complained about the need to > disable the threshold as an extra step in getting logs for support. > Only downsides I see to removing the threshold and adding a priority > to the root logger are: > > 1) behavior change from 5.0.1 (but JBAS-6629/30 are as well, and your > stuff is also a 5.1 change in how logging works, so now seems like the > time.) > > 2) Users have to add a category to get their stuff at finer level vs > just removing the threshold. Which is just another way of saying its a > behavior change. ;) > > This would also have to be commented: > > <!-- Limit JSF logging to DEBUG. FINER and FINEST will not be > logged --> > <category name="javax.enterprise.resource.webcontainer.jsf"> > <priority value="DEBUG" /> > </category> > >> - DML >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development > >