7:20 a.m.
Hi,
I am trying to find a way to improve the behaviour of mod_proxy httpd
and JBossAS when an application is reployed.
For the moment in MainDeployer.java we have something like:
redeploy()
{
undeploy();
deploy();
}
Due to this Tomcat doesn't know that the webapp is being redeployed and
between the first undeploy() and end of deploy() is will return 404.
It is possible to add a ContainerListener in Tomcat but the only things
we get are removeChild and addChild events. It is possible to send a
message to httpd to tell that the context of the webapp is not available
in the node (to try to use another node of the cluster).
I think that to make it clean we need to add a start_redeploy and
end_redeploy event in Tomcat and modify MainDeployer and
AbstractWebDeployer so that the redeploy event could reach the Tomcat
classes.
Comments?
Cheers
Jean-Frederic
11:48 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
undeploy is begining. Are you looking for a distinction between an
unavailable app and one that is being redeployed? I would think not as
there is no guarantee that the redeploy will succeed. I don't see that
the MainDeployer needs to change, just the TomcatDeployer.
Jean-frederic Clere wrote:
Hi,
I am trying to find a way to improve the behaviour of mod_proxy httpd
and JBossAS when an application is reployed.
For the moment in MainDeployer.java we have something like:
redeploy()
{
undeploy();
deploy();
}
Due to this Tomcat doesn't know that the webapp is being redeployed and
between the first undeploy() and end of deploy() is will return 404.
It is possible to add a ContainerListener in Tomcat but the only things
we get are removeChild and addChild events. It is possible to send a
message to httpd to tell that the context of the webapp is not available
in the node (to try to use another node of the cluster).
I think that to make it clean we need to add a start_redeploy and
end_redeploy event in Tomcat and modify MainDeployer and
AbstractWebDeployer so that the redeploy event could reach the Tomcat
classes.
Comments?
Cheers
Jean-Frederic
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
4:11 p.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
Scott M Stark wrote:
The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
undeploy is begining. Are you looking for a distinction between an
unavailable app and one that is being redeployed?
Yes. I know that "there is no guarantee that the redeploy will succeed"
but in production that should not happend and even in this case the
customer probably prefer a 503 to a 404. (If the request cannot be
routed to another node).
I would think not as there is no guarantee that the redeploy will
succeed. I don't see that the MainDeployer needs to change, just the
TomcatDeployer.
The actual TomcatDeployer doesn't know that a redeploy is taking place
how could it inform Tomcat?
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
> Hi,
>
> I am trying to find a way to improve the behaviour of mod_proxy httpd
> and JBossAS when an application is reployed.
> For the moment in MainDeployer.java we have something like:
> redeploy()
> {
> undeploy();
> deploy();
> }
> Due to this Tomcat doesn't know that the webapp is being redeployed and
> between the first undeploy() and end of deploy() is will return 404.
>
> It is possible to add a ContainerListener in Tomcat but the only things
> we get are removeChild and addChild events. It is possible to send a
> message to httpd to tell that the context of the webapp is not available
> in the node (to try to use another node of the cluster).
>
> I think that to make it clean we need to add a start_redeploy and
> end_redeploy event in Tomcat and modify MainDeployer and
> AbstractWebDeployer so that the redeploy event could reach the Tomcat
> classes.
>
> Comments?
>
> Cheers
>
> Jean-Frederic
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
4:48 p.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
The TomcatDeployer knows that an undeploy is being done
(performUndeploy) and can configure tomcat to return 503 until the
completion of the subsequent deploy(performDeploy).
Jean-frederic Clere wrote:
Scott M Stark wrote:
> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
> undeploy is begining. Are you looking for a distinction between an
> unavailable app and one that is being redeployed?
Yes. I know that "there is no guarantee that the redeploy will
succeed" but in production that should not happend and even in this
case the customer probably prefer a 503 to a 404. (If the request
cannot be routed to another node).
> I would think not as there is no guarantee that the redeploy will
> succeed. I don't see that the MainDeployer needs to change, just the
> TomcatDeployer.
The actual TomcatDeployer doesn't know that a redeploy is taking place
how could it inform Tomcat?
Cheers
Jean-Frederic
3:31 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
Still, how does the TomcatDeployer know that a deploy WILL happen
subsequently? (instead of a dumb undeploy with no further re-deploy)?
Scott M Stark wrote:
The TomcatDeployer knows that an undeploy is being done
(performUndeploy) and can configure tomcat to return 503 until the
completion of the subsequent deploy(performDeploy).
Jean-frederic Clere wrote:
> Scott M Stark wrote:
>
>> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
>> undeploy is begining. Are you looking for a distinction between an
>> unavailable app and one that is being redeployed?
>
> Yes. I know that "there is no guarantee that the redeploy will
> succeed" but in production that should not happend and even in this
> case the customer probably prefer a 503 to a 404. (If the request
> cannot be routed to another node).
>
>> I would think not as there is no guarantee that the redeploy will
>> succeed. I don't see that the MainDeployer needs to change, just the
>> TomcatDeployer.
>
> The actual TomcatDeployer doesn't know that a redeploy is taking
> place how could it inform Tomcat?
>
> Cheers
>
> Jean-Frederic
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
3:32 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Wed, 2006-09-20 at 13:48 -0700, Scott M Stark wrote:
The TomcatDeployer knows that an undeploy is being done
(performUndeploy) and can configure tomcat to return 503 until the
completion of the subsequent deploy(performDeploy).
My first goal is not to handle it in Tomcat but in httpd for this a
ContainerListener in Tomcat would be enough. The only thing is to add a
parameter to tell how long an application could stay undeployed
returning 503 before returning 404.
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
> Scott M Stark wrote:
>
>> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
>> undeploy is begining. Are you looking for a distinction between an
>> unavailable app and one that is being redeployed?
>
> Yes. I know that "there is no guarantee that the redeploy will
> succeed" but in production that should not happend and even in this
> case the customer probably prefer a 503 to a 404. (If the request
> cannot be routed to another node).
>
>> I would think not as there is no guarantee that the redeploy will
>> succeed. I don't see that the MainDeployer needs to change, just the
>> TomcatDeployer.
>
> The actual TomcatDeployer doesn't know that a redeploy is taking place
> how could it inform Tomcat?
>
> Cheers
>
> Jean-Frederic
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
3:36 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
What about having the MainDeployer set a thread context variable
indicating whether we are inside a "Redeploy" scenario?
Jean-frederic Clere wrote:
On Wed, 2006-09-20 at 13:48 -0700, Scott M Stark wrote:
> The TomcatDeployer knows that an undeploy is being done
> (performUndeploy) and can configure tomcat to return 503 until the
> completion of the subsequent deploy(performDeploy).
>
My first goal is not to handle it in Tomcat but in httpd for this a
ContainerListener in Tomcat would be enough. The only thing is to add a
parameter to tell how long an application could stay undeployed
returning 503 before returning 404.
Cheers
Jean-Frederic
> Jean-frederic Clere wrote:
>
>> Scott M Stark wrote:
>>
>>
>>> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
>>> undeploy is begining. Are you looking for a distinction between an
>>> unavailable app and one that is being redeployed?
>>>
>> Yes. I know that "there is no guarantee that the redeploy will
>> succeed" but in production that should not happend and even in this
>> case the customer probably prefer a 503 to a 404. (If the request
>> cannot be routed to another node).
>>
>>
>>> I would think not as there is no guarantee that the redeploy will
>>> succeed. I don't see that the MainDeployer needs to change, just the
>>> TomcatDeployer.
>>>
>> The actual TomcatDeployer doesn't know that a redeploy is taking place
>> how could it inform Tomcat?
>>
>> Cheers
>>
>> Jean-Frederic
>>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
4:22 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
What about having the MainDeployer set a thread context variable
indicating whether we are inside a "Redeploy" scenario?
MainDeployer knows that it is doing a redeploy(), the problem is just
that the redeploy() should also be in the TomcatDeployer or that
MainDeployer should tell to the TomcatDeployer that the undeploy() is
called for a redeploy() (like undeploy(false) for a redeployement and
undeploy(true) for an undeployement).
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
> On Wed, 2006-09-20 at 13:48 -0700, Scott M Stark wrote:
>
>> The TomcatDeployer knows that an undeploy is being done
>> (performUndeploy) and can configure tomcat to return 503 until the
>> completion of the subsequent deploy(performDeploy).
>>
>
> My first goal is not to handle it in Tomcat but in httpd for this a
> ContainerListener in Tomcat would be enough. The only thing is to add a
> parameter to tell how long an application could stay undeployed
> returning 503 before returning 404.
>
> Cheers
>
> Jean-Frederic
>
>
>> Jean-frederic Clere wrote:
>>
>>> Scott M Stark wrote:
>>>
>>>
>>>> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
>>>> undeploy is begining. Are you looking for a distinction between an
>>>> unavailable app and one that is being redeployed?
>>>>
>>> Yes. I know that "there is no guarantee that the redeploy will
>>> succeed" but in production that should not happend and even in this
>>> case the customer probably prefer a 503 to a 404. (If the request
>>> cannot be routed to another node).
>>>
>>>
>>>> I would think not as there is no guarantee that the redeploy will
>>>> succeed. I don't see that the MainDeployer needs to change, just the
>>>> TomcatDeployer.
>>>>
>>> The actual TomcatDeployer doesn't know that a redeploy is taking place
>>> how could it inform Tomcat?
>>>
>>> Cheers
>>>
>>> Jean-Frederic
>>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
8:37 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
That is what I mean: the MainDeployer could "share" this knowledge that
it is a redeploy with any other piece of code, including the
tomcatdeployer, by setting a temporary thread local variable that could
be checked by any deployer.
Jean-frederic Clere wrote:
On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
> What about having the MainDeployer set a thread context variable
> indicating whether we are inside a "Redeploy" scenario?
>
MainDeployer knows that it is doing a redeploy(), the problem is just
that the redeploy() should also be in the TomcatDeployer or that
MainDeployer should tell to the TomcatDeployer that the undeploy() is
called for a redeploy() (like undeploy(false) for a redeployement and
undeploy(true) for an undeployement).
Cheers
Jean-Frederic
> Jean-frederic Clere wrote:
>
>> On Wed, 2006-09-20 at 13:48 -0700, Scott M Stark wrote:
>>
>>
>>> The TomcatDeployer knows that an undeploy is being done
>>> (performUndeploy) and can configure tomcat to return 503 until the
>>> completion of the subsequent deploy(performDeploy).
>>>
>>>
>> My first goal is not to handle it in Tomcat but in httpd for this a
>> ContainerListener in Tomcat would be enough. The only thing is to add a
>> parameter to tell how long an application could stay undeployed
>> returning 503 before returning 404.
>>
>> Cheers
>>
>> Jean-Frederic
>>
>>
>>
>>> Jean-frederic Clere wrote:
>>>
>>>
>>>> Scott M Stark wrote:
>>>>
>>>>
>>>>
>>>>> The AbstractWebDeployer/TomcatDeployer can inform tomcat that an
>>>>> undeploy is begining. Are you looking for a distinction between an
>>>>> unavailable app and one that is being redeployed?
>>>>>
>>>>>
>>>> Yes. I know that "there is no guarantee that the redeploy will
>>>> succeed" but in production that should not happend and even in this
>>>> case the customer probably prefer a 503 to a 404. (If the request
>>>> cannot be routed to another node).
>>>>
>>>>
>>>>
>>>>> I would think not as there is no guarantee that the redeploy will
>>>>> succeed. I don't see that the MainDeployer needs to change, just
the
>>>>> TomcatDeployer.
>>>>>
>>>>>
>>>> The actual TomcatDeployer doesn't know that a redeploy is taking
place
>>>> how could it inform Tomcat?
>>>>
>>>> Cheers
>>>>
>>>> Jean-Frederic
>>>>
>>>>
>>> _______________________________________________
>>> jboss-development mailing list
>>> jboss-development(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>>
>>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>
>>
>>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
10:27 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
Redeploy is not used during a hot-redeploy. The URLDeploymentScanner
simply does an undeploy/deploy the same as the redeploy in main. Both
the scanner and main deployer need to be marking a deployment as in the
process of being redeployed. This should be propagated via the
DeploymentInfo and WebApplication.
Sacha Labourey wrote:
That is what I mean: the MainDeployer could "share" this
knowledge
that it is a redeploy with any other piece of code, including the
tomcatdeployer, by setting a temporary thread local variable that
could be checked by any deployer.
Jean-frederic Clere wrote:
> On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
>
>> What about having the MainDeployer set a thread context variable
>> indicating whether we are inside a "Redeploy" scenario?
>>
>
> MainDeployer knows that it is doing a redeploy(), the problem is just
> that the redeploy() should also be in the TomcatDeployer or that
> MainDeployer should tell to the TomcatDeployer that the undeploy() is
> called for a redeploy() (like undeploy(false) for a redeployement and
> undeploy(true) for an undeployement).
>
> Cheers
>
> Jean-Frederic
>
9 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Thu, 2006-09-21 at 07:27 -0700, Scott M Stark wrote:
Redeploy is not used during a hot-redeploy. The URLDeploymentScanner
simply does an undeploy/deploy the same as the redeploy in main.
Well URLDeploymentScanner only passes the URL, how do I get the
information that it is a redeployement in MainDeployer?
Cheers
Jean-Frederic
Both
the scanner and main deployer need to be marking a deployment as in the
process of being redeployed. This should be propagated via the
DeploymentInfo and WebApplication.
Sacha Labourey wrote:
> That is what I mean: the MainDeployer could "share" this knowledge
> that it is a redeploy with any other piece of code, including the
> tomcatdeployer, by setting a temporary thread local variable that
> could be checked by any deployer.
>
> Jean-frederic Clere wrote:
>> On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
>>
>>> What about having the MainDeployer set a thread context variable
>>> indicating whether we are inside a "Redeploy" scenario?
>>>
>>
>> MainDeployer knows that it is doing a redeploy(), the problem is just
>> that the redeploy() should also be in the TomcatDeployer or that
>> MainDeployer should tell to the TomcatDeployer that the undeploy() is
>> called for a redeploy() (like undeploy(false) for a redeployement and
>> undeploy(true) for an undeployement).
>>
>> Cheers
>>
>> Jean-Frederic
>>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
10:24 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
What you are looking for is for what happens at line 391-392 here:
http://fisheye.jboss.org/browse/JBoss/jboss-system/src/main/org/jboss/dep...
Jean-frederic Clere wrote:
On Thu, 2006-09-21 at 07:27 -0700, Scott M Stark wrote:
> Redeploy is not used during a hot-redeploy. The URLDeploymentScanner
> simply does an undeploy/deploy the same as the redeploy in main.
>
Well URLDeploymentScanner only passes the URL, how do I get the
information that it is a redeployement in MainDeployer?
Cheers
Jean-Frederic
> Both
> the scanner and main deployer need to be marking a deployment as in the
> process of being redeployed. This should be propagated via the
> DeploymentInfo and WebApplication.
>
> Sacha Labourey wrote:
>
>> That is what I mean: the MainDeployer could "share" this knowledge
>> that it is a redeploy with any other piece of code, including the
>> tomcatdeployer, by setting a temporary thread local variable that
>> could be checked by any deployer.
>>
>> Jean-frederic Clere wrote:
>>
>>> On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
>>>
>>>
>>>> What about having the MainDeployer set a thread context variable
>>>> indicating whether we are inside a "Redeploy" scenario?
>>>>
>>>>
>>> MainDeployer knows that it is doing a redeploy(), the problem is just
>>> that the redeploy() should also be in the TomcatDeployer or that
>>> MainDeployer should tell to the TomcatDeployer that the undeploy() is
>>> called for a redeploy() (like undeploy(false) for a redeployement and
>>> undeploy(true) for an undeployement).
>>>
>>> Cheers
>>>
>>> Jean-Frederic
>>>
>>>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
11:01 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Fri, 2006-09-22 at 16:24 +0200, Sacha Labourey wrote:
What you are looking for is for what happens at line 391-392 here:
http://fisheye.jboss.org/browse/JBoss/jboss-system/src/main/org/jboss/dep...
The problem is the URLDeploymentScanner uses the interface Deployer to
reach MainDeployer.
It is not possible to add a redeploy method to Deployer because that
would break the interface (may be customer have their own Deployer).
The undeploy method in Deployer is:
void undeploy(URL url) throws DeploymentException;
The information must be stored somewhere.
Any hints?
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
> On Thu, 2006-09-21 at 07:27 -0700, Scott M Stark wrote:
>
>> Redeploy is not used during a hot-redeploy. The URLDeploymentScanner
>> simply does an undeploy/deploy the same as the redeploy in main.
>>
>
> Well URLDeploymentScanner only passes the URL, how do I get the
> information that it is a redeployement in MainDeployer?
>
> Cheers
>
> Jean-Frederic
>
>
>> Both
>> the scanner and main deployer need to be marking a deployment as in the
>> process of being redeployed. This should be propagated via the
>> DeploymentInfo and WebApplication.
>>
>> Sacha Labourey wrote:
>>
>>> That is what I mean: the MainDeployer could "share" this knowledge
>>> that it is a redeploy with any other piece of code, including the
>>> tomcatdeployer, by setting a temporary thread local variable that
>>> could be checked by any deployer.
>>>
>>> Jean-frederic Clere wrote:
>>>
>>>> On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
>>>>
>>>>
>>>>> What about having the MainDeployer set a thread context variable
>>>>> indicating whether we are inside a "Redeploy" scenario?
>>>>>
>>>>>
>>>> MainDeployer knows that it is doing a redeploy(), the problem is just
>>>> that the redeploy() should also be in the TomcatDeployer or that
>>>> MainDeployer should tell to the TomcatDeployer that the undeploy() is
>>>> called for a redeploy() (like undeploy(false) for a redeployement and
>>>> undeploy(true) for an undeployement).
>>>>
>>>> Cheers
>>>>
>>>> Jean-Frederic
>>>>
>>>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
11:51 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
Oh, oh!! very creative! :)
Scott M Stark wrote:
You can pass in a hint as a url parameter
"file:/.../deploy/my.war?redeploy=true" so that the main deployer can
set a flag in the deployment.
Jean-frederic Clere wrote:
> On Fri, 2006-09-22 at 16:24 +0200, Sacha Labourey wrote:
>
>> What you are looking for is for what happens at line 391-392 here:
>>
http://fisheye.jboss.org/browse/JBoss/jboss-system/src/main/org/jboss/dep...
>>
>
> The problem is the URLDeploymentScanner uses the interface Deployer to
> reach MainDeployer.
> It is not possible to add a redeploy method to Deployer because that
> would break the interface (may be customer have their own Deployer).
> The undeploy method in Deployer is:
> void undeploy(URL url) throws DeploymentException;
> The information must be stored somewhere.
>
> Any hints?
>
> Cheers
>
> Jean-Frederic
>
>
------------------------------------------------------------------------
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
4:41 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Fri, 2006-09-22 at 08:37 -0700, Scott M Stark wrote:
You can pass in a hint as a url parameter
"file:/.../deploy/my.war?
redeploy=true" so that the main deployer can set a flag in the
deployment.
Ok, this seems to work. Now I have the information that the undeploy()
occurs in MainDeployer because of a redeployment.
To send the information to my listener (and later to Apache httpd) I am
thinking of using a Notification("StartReDeploy", ...) and use the
DeploymentInfo to have the Host and the Context information.
Any comments?
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
> On Fri, 2006-09-22 at 16:24 +0200, Sacha Labourey wrote:
>
> > What you are looking for is for what happens at line 391-392 here:
> >
http://fisheye.jboss.org/browse/JBoss/jboss-system/src/main/org/jboss/dep...
> >
>
> The problem is the URLDeploymentScanner uses the interface Deployer to
> reach MainDeployer.
> It is not possible to add a redeploy method to Deployer because that
> would break the interface (may be customer have their own Deployer).
> The undeploy method in Deployer is:
> void undeploy(URL url) throws DeploymentException;
> The information must be stored somewhere.
>
> Any hints?
>
> Cheers
>
> Jean-Frederic
>
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
3:28 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Wed, 2006-09-27 at 13:18 -0700, Scott M Stark wrote:
The notification type should be added to the existing
MainDeployerConstants
org.jboss.deployment.MainDeployerConstants
{
/** The JMX notification type sent when a deployer is added */
public static final String ADD_DEPLOYER =
"org.jboss.deployment.MainDeployer.addDeployer";
/** The JMX notification type sent when a deployer is removed */
public static final String REMOVE_DEPLOYER =
"org.jboss.deployment.MainDeployer.removeDeployer";
/** The JMX notification type sent when a deploy is performed */
public static final String DEPLOY =
"org.jboss.deployment.MainDeployer.deploy";
/** The JMX notification type sent when a undeploy is performed */
public static final String UNDEPLOY =
"org.jboss.deployment.MainDeployer.undeploy";
/** The JMX notification type sent when a undeploy/deploy cycle is
performed */
public static final String REDEPLOY =
"org.jboss.deployment.MainDeployer.redeploy";
}
One question is whether there should be BEGIN_DEPLOY/END_DEPLOY
notifications that would allow one to determine the outcome of the
deploy.
That means we would need:
BEGIN_DEPLOY/END_DEPLOY
BEGIN_REDEPLOY/END_REDEPLOY
BEGIN_UNDEPLOY/END_UNDEPLOY
to be able to know the result of the action, wouldn't we?
In fact to prevent the 404 I just need to forward the BEGIN_REDEPLOY to
Apache httpd. (Tomcat has its event to tell that a Context is up again).
Cheers
Jean-Frederic
Most likely a begin/end notification is the cleanest way to
introduce
the notifications.
/** The JMX notification type sent when a undeploy i
Jean-frederic Clere wrote:
> On Fri, 2006-09-22 at 08:37 -0700, Scott M Stark wrote:
>
> > You can pass in a hint as a url parameter "file:/.../deploy/my.war?
> > redeploy=true" so that the main deployer can set a flag in the
> > deployment.
> >
>
> Ok, this seems to work. Now I have the information that the undeploy()
> occurs in MainDeployer because of a redeployment.
>
> To send the information to my listener (and later to Apache httpd) I am
> thinking of using a Notification("StartReDeploy", ...) and use the
> DeploymentInfo to have the Host and the Context information.
>
> Any comments?
>
> Cheers
>
> Jean-Frederic
>
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
5:48 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
On Thu, 2006-09-28 at 05:44 -0700, Scott M Stark wrote:
Yes, all 6 should be added to be consistent. If the tomcat deployer
is
going to handle the notification at the end of a deploy which is
associated with a redeploy, why can't it it do the initial
notification at the start of undeploy by looking to the
DeploymentInfo.isRedeploy flag?
Yes if isRedeploy is added to DeploymentInfo.
Cheers
Jean-Frederic
Jean-frederic Clere wrote:
>
> That means we would need:
> BEGIN_DEPLOY/END_DEPLOY
> BEGIN_REDEPLOY/END_REDEPLOY
> BEGIN_UNDEPLOY/END_UNDEPLOY
> to be able to know the result of the action, wouldn't we?
>
> In fact to prevent the 404 I just need to forward the BEGIN_REDEPLOY to
> Apache httpd. (Tomcat has its event to tell that a Context is up again).
>
> Cheers
>
> Jean-Frederic
>
>
> > Most likely a begin/end notification is the cleanest way to introduce
> > the notifications.
> > /** The JMX notification type sent when a undeploy i
> >
> > Jean-frederic Clere wrote:
> >
> > > On Fri, 2006-09-22 at 08:37 -0700, Scott M Stark wrote:
> > >
> > >
> > > > You can pass in a hint as a url parameter
"file:/.../deploy/my.war?
> > > > redeploy=true" so that the main deployer can set a flag in the
> > > > deployment.
> > > >
> > > >
> > > Ok, this seems to work. Now I have the information that the undeploy()
> > > occurs in MainDeployer because of a redeployment.
> > >
> > > To send the information to my listener (and later to Apache httpd) I am
> > > thinking of using a Notification("StartReDeploy", ...) and use
the
> > > DeploymentInfo to have the Host and the Context information.
> > >
> > > Any comments?
> > >
> > > Cheers
> > >
> > > Jean-Frederic
> > >
> > >
> > >
> > _______________________________________________
> > jboss-development mailing list
> > jboss-development(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/jboss-development
> >
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
11:38 a.m.
New subject: [JBoss-dev] httpd and tomcatClustering gives 404 during redeploy.
hum.. .yes... a thread local wouldn't break the interface (in a try
finally block to reset its state afterwards) and handle the rest of the
logic in the deployer directly. 5.0 can work on a cleaner solution with
proper API (ADrian sent a recent e-mail on this about his new metadata
structure)
Jean-frederic Clere wrote:
On Fri, 2006-09-22 at 16:24 +0200, Sacha Labourey wrote:
> What you are looking for is for what happens at line 391-392 here:
>
http://fisheye.jboss.org/browse/JBoss/jboss-system/src/main/org/jboss/dep...
>
The problem is the URLDeploymentScanner uses the interface Deployer to
reach MainDeployer.
It is not possible to add a redeploy method to Deployer because that
would break the interface (may be customer have their own Deployer).
The undeploy method in Deployer is:
void undeploy(URL url) throws DeploymentException;
The information must be stored somewhere.
Any hints?
Cheers
Jean-Frederic
> Jean-frederic Clere wrote:
>
>> On Thu, 2006-09-21 at 07:27 -0700, Scott M Stark wrote:
>>
>>
>>> Redeploy is not used during a hot-redeploy. The URLDeploymentScanner
>>> simply does an undeploy/deploy the same as the redeploy in main.
>>>
>>>
>> Well URLDeploymentScanner only passes the URL, how do I get the
>> information that it is a redeployement in MainDeployer?
>>
>> Cheers
>>
>> Jean-Frederic
>>
>>
>>
>>> Both
>>> the scanner and main deployer need to be marking a deployment as in the
>>> process of being redeployed. This should be propagated via the
>>> DeploymentInfo and WebApplication.
>>>
>>> Sacha Labourey wrote:
>>>
>>>
>>>> That is what I mean: the MainDeployer could "share" this
knowledge
>>>> that it is a redeploy with any other piece of code, including the
>>>> tomcatdeployer, by setting a temporary thread local variable that
>>>> could be checked by any deployer.
>>>>
>>>> Jean-frederic Clere wrote:
>>>>
>>>>
>>>>> On Thu, 2006-09-21 at 09:36 +0200, Sacha Labourey wrote:
>>>>>
>>>>>
>>>>>
>>>>>> What about having the MainDeployer set a thread context variable
>>>>>> indicating whether we are inside a "Redeploy"
scenario?
>>>>>>
>>>>>>
>>>>>>
>>>>> MainDeployer knows that it is doing a redeploy(), the problem is
just
>>>>> that the redeploy() should also be in the TomcatDeployer or that
>>>>> MainDeployer should tell to the TomcatDeployer that the undeploy()
is
>>>>> called for a redeploy() (like undeploy(false) for a redeployement
and
>>>>> undeploy(true) for an undeployement).
>>>>>
>>>>> Cheers
>>>>>
>>>>> Jean-Frederic
>>>>>
>>>>>
>>>>>
>>> _______________________________________________
>>> jboss-development mailing list
>>> jboss-development(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>>
>>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>
>>
>>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
>
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
6508
days inactive
6520
days old
jboss-development@lists.jboss.org
20 comments
4 participants
participants (4)
-
Jean-frederic Clere -
Sacha Labourey -
Scott M Stark -
Scott M Stark