Re: [jboss-dev] JPA Deployers VFS Abstraction

On Feb 18, 2010, at 8:36 AM, Carlo de Wolf wrote: > On 02/17/2010 10:43 PM, John Bailey wrote: > >> I have added the VFS abstraction projects to jboss-jpa and jboss-jpa-deployers is no longer referencing VFS as a compile time dependency. The jpa-dployers component loads the correct VFS adapter based on a ServiceLoader mechanism. I have tested the the component on the current JBossAS trunk as well as the VFS3 branch, and both load the correct adapter. >> >> > I only have one small point: the RuntimeExceptions in PersistenceUnitDeploymentFactory must reference either spec or a Jira (since spec is not applicable). > I am not entirely clear what you mean here.

>> If this looks good, we will need to move forward with cutting a release for jboss-jpa-deployers, jboss-jpa-vfs2 and jboss-jpa-vfs3. Then I will go through and integrate the correct adapters in AS trunk and the VFS3 branch. Sounds good? >> >> > I want to see the test results for vfs2, preferably including TCK. The full vfs3 test will be later on. :-) > Maybe put trunk on a snapshot or timestamp dependency? > I have setup a local checkout of AS trunk with the updated JPA deployer and VFS2 adapter. I have run the smoke-tests and some test JPA deployments. I can fire of the full testsuite as well as the TCK. I will let you know how it goes. >> Also, I think this proves the ServiceLoader model will work with EJB3 as well. What do you think? >> >> > The DeploymentUnit is created within AS itself, so we wouldn't need a ServiceLoader. > >> John >> >> >> >> >> > Carlo > -- John Bailey JBoss by Red Hat --