7:21 p.m.
Hi Scott/Carlo,
Re: http://jira.jboss.com/jira/browse/JBAS-5471
I've fixed this applying the changes in the attached patch. Explanation
of the resolution can be found in the comments I made in the JIRA. As I
hardly know this area, could you please review it?
Cheers,
--
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
Index:
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java
===================================================================
---
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java (revision
72518)
+++
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/Ejb3JBoss5Deployment.java (working
copy)
@@ -28,10 +28,10 @@
import org.jboss.ejb3.DeploymentScope;
import org.jboss.ejb3.DeploymentUnit;
import org.jboss.ejb3.Ejb3Deployment;
-import org.jboss.ejb3.MCKernelAbstraction;
import org.jboss.ejb3.javaee.JavaEEComponent;
import org.jboss.ejb3.metadata.jpa.spec.PersistenceUnitsMetaData;
import org.jboss.kernel.Kernel;
+import org.jboss.logging.Logger;
import org.jboss.metadata.ejb.jboss.JBossMetaData;
/**
@@ -39,6 +39,7 @@
*
* @author <a href="mailto:bill@jboss.org">Bill Burke</a>
* @author adrian(a)jboss.org
+ * @author <a href="mailto:galder.zamarreno@jboss.com">Galder
Zamarreno</a>
* @version $Revision: 56592 $
*/
public class Ejb3JBoss5Deployment extends Ejb3Deployment
@@ -43,6 +44,8 @@
*/
public class Ejb3JBoss5Deployment extends Ejb3Deployment
{
+ private static final Logger log = Logger.getLogger(Ejb3JBoss5Deployment.class);
+
private org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit;
public Ejb3JBoss5Deployment(DeploymentUnit ejb3Unit, Kernel kernel, MBeanServer
mbeanServer, org.jboss.deployers.structure.spi.DeploymentUnit jbossUnit, DeploymentScope
deploymentScope, JBossMetaData metaData, PersistenceUnitsMetaData
persistenceUnitsMetaData)
@@ -51,7 +54,13 @@
this.jbossUnit = jbossUnit;
kernelAbstraction = new JBossASKernel(kernel);
- // todo maybe mbeanServer should be injected?
+ // inject mbean server
+ if (log.isTraceEnabled())
+ {
+ log.trace("Inject mbean server in kernel abstraction.");
+ }
+ kernelAbstraction.setMbeanServer(mbeanServer);
+
this.mbeanServer = mbeanServer;
}
Index:
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/JBossASKernel.java
===================================================================
---
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/JBossASKernel.java (revision
72518)
+++
/home/galder/jboss/code/as/trunk.ejbthree-1015/ejb3/src/main/org/jboss/ejb3/deployers/JBossASKernel.java (working
copy)
@@ -34,7 +34,6 @@
import javax.management.MBeanServer;
import javax.management.ObjectName;
import javax.management.ReflectionException;
-import javax.management.RuntimeMBeanException;
import org.jboss.beans.metadata.plugins.AbstractBeanMetaData;
import org.jboss.beans.metadata.plugins.AbstractConstructorMetaData;
@@ -40,7 +39,6 @@
import org.jboss.beans.metadata.plugins.AbstractConstructorMetaData;
import org.jboss.beans.metadata.plugins.AbstractDemandMetaData;
import org.jboss.beans.metadata.plugins.AbstractValueMetaData;
-import org.jboss.beans.metadata.spi.BeanMetaData;
import org.jboss.beans.metadata.spi.BeanMetaDataFactory;
import org.jboss.beans.metadata.spi.DemandMetaData;
import org.jboss.beans.metadata.spi.SupplyMetaData;
@@ -59,6 +57,7 @@
* The JBossAS implementation of the ejb3 KernelAbstraction integration api
* @author <a href="mailto:bill@jboss.org">Bill Burke</a>
* @author Scott.Stark(a)jboss.org
+ * @author <a href="mailto:galder.zamarreno@jboss.com">Galder
Zamarreno</a>
* @version $Revision:$
*/
public class JBossASKernel
@@ -137,7 +136,6 @@
try
{
mbeanServer.registerMBean(service, on);
- install(on.getCanonicalName(), dependencies, null, service);
// EJBTHREE-606: emulate the ServiceController calls
MBeanInfo info = mbeanServer.getMBeanInfo(on); // redundant call for speed
7:30 p.m.
I'll have to pull down the beta4 branch source to see what we were doing
with kernel abstraction in that version.
Galder Zamarreno wrote:
Hi Scott/Carlo,
Re: http://jira.jboss.com/jira/browse/JBAS-5471
I've fixed this applying the changes in the attached patch.
Explanation of the resolution can be found in the comments I made in
the JIRA. As I hardly know this area, could you please review it?
Cheers,
7:44 p.m.
Actually, a question on this: Where are the EJB3 integration tests
living now? IOW, tests that ensure deployment of EJB3 artifacts, such as
this EJB3 service in AS? Are they disabled by any chance?
Galder Zamarreno wrote:
Hi Scott/Carlo,
Re: http://jira.jboss.com/jira/browse/JBAS-5471
I've fixed this applying the changes in the attached patch. Explanation
of the resolution can be found in the comments I made in the JIRA. As I
hardly know this area, could you please review it?
Cheers,
------------------------------------------------------------------------
_______________________________________________
jboss-development mailing list
jboss-development(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-development
--
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
8 p.m.
Integration specific tests are in jbossas/testsuite. The ejb3-core tests
still have a lot of integration tests:
http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
Galder Zamarreno wrote:
Actually, a question on this: Where are the EJB3 integration tests
living now? IOW, tests that ensure deployment of EJB3 artifacts, such
as this EJB3 service in AS? Are they disabled by any chance?
Galder Zamarreno wrote:
> Hi Scott/Carlo,
>
> Re: http://jira.jboss.com/jira/browse/JBAS-5471
>
> I've fixed this applying the changes in the attached patch.
> Explanation of the resolution can be found in the comments I made in
> the JIRA. As I hardly know this area, could you please review it?
>
> Cheers,
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> jboss-development mailing list
> jboss-development(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development
8:30 p.m.
Scott Stark wrote:
Integration specific tests are in jbossas/testsuite. The ejb3-core
tests
still have a lot of integration tests:
http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
In this particular case, assuming that the code I wanna be fixing lives
in AS within the ejb3 integration layer, any test case I create for
this should live in AS, correct?
I don't see any org.jboss.test.ejb3 package to test the ejb3 integration
layer in jbossas/testsuite unless these tests are located somewhere else.
Or do you expect a test case to fix JBAS-5471, assuming the fix only
involved fixing the ejb3 integration layer in AS, to live in the ejb3
project? I'm sure there's such test there but probably those tests
haven't run yet as the EJB3 team are currently trying to untangle the
dependency issues.
Galder Zamarreno wrote:
> Actually, a question on this: Where are the EJB3 integration tests
> living now? IOW, tests that ensure deployment of EJB3 artifacts, such
> as this EJB3 service in AS? Are they disabled by any chance?
>
> Galder Zamarreno wrote:
>> Hi Scott/Carlo,
>>
>> Re: http://jira.jboss.com/jira/browse/JBAS-5471
>>
>> I've fixed this applying the changes in the attached patch.
>> Explanation of the resolution can be found in the comments I made in
>> the JIRA. As I hardly know this area, could you please review it?
>>
>> Cheers,
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> jboss-development mailing list
>> jboss-development(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-development
>
--
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
8:39 p.m.
There is no specific org.jboss.test.ejb3 package as the tests are
packaged more along the lines of the function. Create an
org.jboss.test.ejb3.service package under the testsuite module and add
your testcase.
The code in question is part of the jbossas/ejb3 deployers integration code.
Galder Zamarreno wrote:
Scott Stark wrote:
> Integration specific tests are in jbossas/testsuite. The ejb3-core
> tests still have a lot of integration tests:
>
> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
In this particular case, assuming that the code I wanna be fixing
lives in AS within the ejb3 integration layer, any test case I create
for this should live in AS, correct?
I don't see any org.jboss.test.ejb3 package to test the ejb3
integration layer in jbossas/testsuite unless these tests are located
somewhere else.
Or do you expect a test case to fix JBAS-5471, assuming the fix only
involved fixing the ejb3 integration layer in AS, to live in the ejb3
project? I'm sure there's such test there but probably those tests
haven't run yet as the EJB3 team are currently trying to untangle the
dependency issues.
7:39 p.m.
I've been thinking through this a bit further, so please bear with me :)
To be mote precise, my test case is just a simple EJB3 service I'm
trying to deploy. Right now, this is just an example I have and haven't
integrated into any testsuite or anything.
(Side note: I'm doing all this cos I was trying to verify whether
http://jira.jboss.com/jira/browse/EJBTHREE-1015 fails in trunk as well.)
So, unless EJB3 team are planning to move such tests into AS testsuite
(They have AS deployment tests in EJB3 project), I have the feeling it
might be pointless for me to add another deployment, in-AS, test to
org.jboss.test.ejb3.service in jbossas/testsuite. Am I right? Judging
from the link you passed me, they already have such type of tests there.
What probably makes more sense is for org.jboss.test.ejb3.service
package (or if diving by lines of function, which I'm happy with,
org.jboss.test.deployers.ejb3, bearing in mind that I'm trying to test
code in org.jboss.ejb3.deployers.*) within jbossas/testsuite to contain
standalone unit test that mocks other parts and tests the integration
code itself.
I can see adding more value with the latter rather than repeating a EJB3
service deployment test within jbossas/testsuite and I'm more than happy
to do such thing.
Does this make any sense?
Scott Stark wrote:
There is no specific org.jboss.test.ejb3 package as the tests are
packaged more along the lines of the function. Create an
org.jboss.test.ejb3.service package under the testsuite module and add
your testcase.
The code in question is part of the jbossas/ejb3 deployers integration
code.
Galder Zamarreno wrote:
>
>
> Scott Stark wrote:
>> Integration specific tests are in jbossas/testsuite. The ejb3-core
>> tests still have a lot of integration tests:
>>
>> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>
> In this particular case, assuming that the code I wanna be fixing
> lives in AS within the ejb3 integration layer, any test case I create
> for this should live in AS, correct?
>
> I don't see any org.jboss.test.ejb3 package to test the ejb3
> integration layer in jbossas/testsuite unless these tests are located
> somewhere else.
>
> Or do you expect a test case to fix JBAS-5471, assuming the fix only
> involved fixing the ejb3 integration layer in AS, to live in the ejb3
> project? I'm sure there's such test there but probably those tests
> haven't run yet as the EJB3 team are currently trying to untangle the
> dependency issues.
--
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
7:39 p.m.
I've been thinking through this a bit further, so please bear with me :)
To be mote precise, my test case is just a simple EJB3 service I'm
trying to deploy. Right now, this is just an example I have and haven't
integrated into any testsuite or anything.
(Side note: I'm doing all this cos I was trying to verify whether
http://jira.jboss.com/jira/browse/EJBTHREE-1015 fails in trunk as well.)
So, unless EJB3 team are planning to move such tests into AS testsuite
(They have AS deployment tests in EJB3 project), I have the feeling it
might be pointless for me to add another deployment, in-AS, test to
org.jboss.test.ejb3.service in jbossas/testsuite. Am I right? Judging
from the link you passed me, they already have such type of tests there.
What probably makes more sense is for org.jboss.test.ejb3.service
package (or if diving by lines of function, which I'm happy with,
org.jboss.test.deployers.ejb3, bearing in mind that I'm trying to test
code in org.jboss.ejb3.deployers.*) within jbossas/testsuite to contain
standalone unit test that mocks other parts and tests the integration
code itself.
I can see adding more value with the latter rather than repeating a EJB3
service deployment test within jbossas/testsuite and I'm more than happy
to do such thing.
Does this make any sense? Carlo?
Scott Stark wrote:
There is no specific org.jboss.test.ejb3 package as the tests are
packaged more along the lines of the function. Create an
org.jboss.test.ejb3.service package under the testsuite module and add
your testcase.
The code in question is part of the jbossas/ejb3 deployers integration
code.
Galder Zamarreno wrote:
>
>
> Scott Stark wrote:
>> Integration specific tests are in jbossas/testsuite. The ejb3-core
>> tests still have a lot of integration tests:
>>
>> http://wiki.jboss.org/wiki/DevEJB3RunningUnitTests
>
> In this particular case, assuming that the code I wanna be fixing
> lives in AS within the ejb3 integration layer, any test case I create
> for this should live in AS, correct?
>
> I don't see any org.jboss.test.ejb3 package to test the ejb3
> integration layer in jbossas/testsuite unless these tests are located
> somewhere else.
>
> Or do you expect a test case to fix JBAS-5471, assuming the fix only
> involved fixing the ejb3 integration layer in AS, to live in the ejb3
> project? I'm sure there's such test there but probably those tests
> haven't run yet as the EJB3 team are currently trying to untangle the
> dependency issues.
--
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat
5856
days inactive
5857
days old
jboss-development@lists.jboss.org
7 comments
2 participants
participants (2)
-
Galder Zamarreno -
Scott Stark