After the removal of the transaction module, booting the 'default' and 'all' configs complains initially for the missing org.jboss.tm.XidFactory, then about missing jbossts libs... _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

I just noticed Franscisco's check-ins this morning. I think we need to revert the changes for now, but unfortunately the check-ins done were multiple. Adrian wrote: > Why has the transaction module been removed? > > The stuff required to make this work properly is still WIP: > http://jira.jboss.com/jira/browse/JBAS-4516 > > In fact, I'm currently working on fixing up the testsuite > to make this possible at all. > > The XIDFactory stuff is expected as per the subtask: > http://jira.jboss.com/jira/browse/JBAS-4517 > > On Thu, 2007-10-04 at 16:12 +0300, Dimitris Andreadis wrote: >> After the removal of the transaction module, booting the 'default' >> and 'all' configs complains initially for the missing >> org.jboss.tm.XidFactory, then about missing jbossts libs... >> >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

I think you're correct, there's lots of little commits. :-( After reverting the transaction module change, I've now got problems with the MDB's ServerSessionPool. Caused by: java.lang.ClassNotFoundException: No ClassLoaders found for: org.jboss.jms.asf.ServerSessionPoolLoader at org.jboss.mx.loading.LoadMgr3.beginLoadTask(LoadMgr3.java:306) at org.jboss.mx.loading.UnifiedClassLoader.loadClassImpl(UnifiedClassLoader.java:290) An alternative strategy would be try to complete Francisco's change by fixing the main configuration of the server. But this will leave lots of broken tests in the testsuite until they are also updated with the correct configuration. e.g. MDB tests with specific JMSContainerInvoker configuration will fail until they are updated to use the JCA 1.5 inbound resource adapter config. e.g.2 There's still lots of tests using the now non-existant org.jboss.tm.TxManager on the client side. Also, the embedded project is broken since it hasn't yet been updated to use the new TM. On Thu, 2007-10-04 at 16:47 +0300, Dimitris Andreadis wrote: > Those are the revision numbers (first one was last): > > Should we revert one by one in reverse order? > > 65826, 65825, 65820, 65819, 65818, 65817, 65816, 65815, 65814, 65813, 65812, 65811, 65810, > 65809, 65808, 65807, 65806 > > Dimitris Andreadis wrote: >> I just noticed Franscisco's check-ins this morning. I think we need to >> revert the changes for now, but unfortunately the check-ins done were >> multiple. >> >> Adrian wrote: >>> Why has the transaction module been removed? >>> >>> The stuff required to make this work properly is still WIP: >>> http://jira.jboss.com/jira/browse/JBAS-4516 >>> >>> In fact, I'm currently working on fixing up the testsuite >>> to make this possible at all. >>> >>> The XIDFactory stuff is expected as per the subtask: >>> http://jira.jboss.com/jira/browse/JBAS-4517 >>> >>> On Thu, 2007-10-04 at 16:12 +0300, Dimitris Andreadis wrote: >>>> After the removal of the transaction module, booting the 'default' >>>> and 'all' configs complains initially for the missing >>>> org.jboss.tm.XidFactory, then about missing jbossts libs... >>>> >>>> _______________________________________________ >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development

Let me do it. I'm nearly there in getting a minimum of rollbacks to make the server boot. Once I've done that I'll commit it so that others can work, then I'll do the rest afterwards. On Thu, 2007-10-04 at 17:04 +0300, Dimitris Andreadis wrote: > I'll try to see if reverting those changes locally works, then try a rollback in a single > commit. > > Adrian wrote: >> I think you're correct, there's lots of little commits. :-( >> >> After reverting the transaction module change, I've now got >> problems with the MDB's ServerSessionPool. >> >> Caused by: java.lang.ClassNotFoundException: No ClassLoaders found for: >> org.jboss.jms.asf.ServerSessionPoolLoader >> at >> org.jboss.mx.loading.LoadMgr3.beginLoadTask(LoadMgr3.java:306) >> at >> org.jboss.mx.loading.UnifiedClassLoader.loadClassImpl(UnifiedClassLoader.java:290) >> >> >> An alternative strategy would be try to complete Francisco's >> change by fixing the main configuration of the server. >> >> But this will leave lots of broken tests in the testsuite >> until they are also updated with the correct configuration. >> >> e.g. MDB tests with specific JMSContainerInvoker configuration >> will fail until they are updated to use the JCA 1.5 inbound resource >> adapter config. >> >> e.g.2 There's still lots of tests using the now >> non-existant org.jboss.tm.TxManager on the client side. >> >> Also, the embedded project is broken since it hasn't yet been >> updated to use the new TM. >> >> On Thu, 2007-10-04 at 16:47 +0300, Dimitris Andreadis wrote: >>> Those are the revision numbers (first one was last): >>> >>> Should we revert one by one in reverse order? >>> >>> 65826, 65825, 65820, 65819, 65818, 65817, 65816, 65815, 65814, 65813, 65812, 65811, 65810, >>> 65809, 65808, 65807, 65806 >>> >>> Dimitris Andreadis wrote: >>>> I just noticed Franscisco's check-ins this morning. I think we need to >>>> revert the changes for now, but unfortunately the check-ins done were >>>> multiple. >>>> >>>> Adrian wrote: >>>>> Why has the transaction module been removed? >>>>> >>>>> The stuff required to make this work properly is still WIP: >>>>> http://jira.jboss.com/jira/browse/JBAS-4516 >>>>> >>>>> In fact, I'm currently working on fixing up the testsuite >>>>> to make this possible at all. >>>>> >>>>> The XIDFactory stuff is expected as per the subtask: >>>>> http://jira.jboss.com/jira/browse/JBAS-4517 >>>>> >>>>> On Thu, 2007-10-04 at 16:12 +0300, Dimitris Andreadis wrote: >>>>>> After the removal of the transaction module, booting the 'default' >>>>>> and 'all' configs complains initially for the missing >>>>>> org.jboss.tm.XidFactory, then about missing jbossts libs... >>>>>> >>>>>> _______________________________________________ >>>>>> jboss-development mailing list >>>>>> jboss-development(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>>> _______________________________________________ >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development >>> _______________________________________________ >>> jboss-development mailing list >>> jboss-development(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development

Ok. I've reverted 65815 - transaction project delete 65813 - removal of transaction from build/build.xml 65809 - removal of org.jboss.jms.asf from the server project With those changes the server boots. This has been committed. If you've nearly done the rest, I'll leave them to you, otherwise let me know. On Thu, 2007-10-04 at 17:20 +0300, Dimitris Andreadis wrote: > Ok, I'm nearly there (locally) with an overall rollback of the 17 commits, but won't commit > anything. > > If you somehow get stuck, give me the green light :)

After your commit, I can not apply the overall rollback anymore. If you want me to do specific rollbacks, give me the revision numbers, or I'll leave it as it now. Adrian wrote: > Dimitris, > > You shouldn't revert the following changes > since this is what I asked Francisco to do > under > http://jira.jboss.com/jira/browse/JBAS-4519 > > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > > The following is just tidyup: > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > > And so is this I think? > http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > > On Thu, 2007-10-04 at 16:34 +0200, Adrian wrote: >> Ok. I've reverted >> >> 65815 - transaction project delete >> 65813 - removal of transaction from build/build.xml >> 65809 - removal of org.jboss.jms.asf from the server project >> >> With those changes the server boots. >> This has been committed. >> >> If you've nearly done the rest, I'll leave them to you, >> otherwise let me know. >> >> On Thu, 2007-10-04 at 17:20 +0300, Dimitris Andreadis wrote: >>> Ok, I'm nearly there (locally) with an overall rollback of the 17 commits, but won't commit >>> anything. >>> >>> If you somehow get stuck, give me the green light :) _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

You be able to do: 1) Revert the changes cd jbossas/build svn revert build.xml cd jbossas/server/src/main/org/jboss/jms/asf svn revert * 2) Remove the transaction project (it's probably easier than revert?) rm -rf jbossas/transaction 3) Update to trunk cd jbossas svn update 4) Commit it On Thu, 2007-10-04 at 17:55 +0300, Dimitris Andreadis wrote: > After your commit, I can not apply the overall rollback anymore. If you want me to do > specific rollbacks, give me the revision numbers, or I'll leave it as it now. > > Adrian wrote: >> Dimitris, >> >> You shouldn't revert the following changes >> since this is what I asked Francisco to do >> under >> http://jira.jboss.com/jira/browse/JBAS-4519 >> >> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... >> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... >> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... >> >> The following is just tidyup: >> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... >> >> And so is this I think? >> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... >> >> On Thu, 2007-10-04 at 16:34 +0200, Adrian wrote: >>> Ok. I've reverted >>> >>> 65815 - transaction project delete >>> 65813 - removal of transaction from build/build.xml >>> 65809 - removal of org.jboss.jms.asf from the server project >>> >>> With those changes the server boots. >>> This has been committed. >>> >>> If you've nearly done the rest, I'll leave them to you, >>> otherwise let me know. >>> >>> On Thu, 2007-10-04 at 17:20 +0300, Dimitris Andreadis wrote: >>>> Ok, I'm nearly there (locally) with an overall rollback of the 17 commits, but won't commit >>>> anything. >>>> >>>> If you somehow get stuck, give me the green light :) > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development

Don't worry about it. When you said you couldn't commit, I started working on it. I'm just testing it now. When I looked in more detail, there's some other parts that shouldn't be reverted. e.g. 65825 includes removal of the DTM tests which is correct but also disables some CTS tests which shouldn't be removed. On Thu, 2007-10-04 at 18:22 +0300, Dimitris Andreadis wrote: > I had already done "some" of those step, but my local copy now looks like a mess :) > > I'll start clean :( > > From your list the ones remaining (may need rollback) are: > > 65826 > 65825 > 65818 > 65817 > 65816 > 65814 > 65811 > 65810 > 65807 > > > Adrian wrote: > > You be able to do: > > > > 1) Revert the changes > > > > cd jbossas/build > > svn revert build.xml > > > > cd jbossas/server/src/main/org/jboss/jms/asf > > svn revert * > > > > 2) Remove the transaction project (it's probably easier than revert?) > > rm -rf jbossas/transaction > > > > 3) Update to trunk > > cd jbossas > > svn update > > > > 4) Commit it > > > > On Thu, 2007-10-04 at 17:55 +0300, Dimitris Andreadis wrote: > >> After your commit, I can not apply the overall rollback anymore. If you want me to do > >> specific rollbacks, give me the revision numbers, or I'll leave it as it now. > >> > >> Adrian wrote: > >>> Dimitris, > >>> > >>> You shouldn't revert the following changes > >>> since this is what I asked Francisco to do > >>> under > >>> http://jira.jboss.com/jira/browse/JBAS-4519 > >>> > >>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > >>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > >>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > >>> > >>> The following is just tidyup: > >>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > >>> > >>> And so is this I think? > >>> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas?view=rev&revision=... > >>> > >>> On Thu, 2007-10-04 at 16:34 +0200, Adrian wrote: > >>>> Ok. I've reverted > >>>> > >>>> 65815 - transaction project delete > >>>> 65813 - removal of transaction from build/build.xml > >>>> 65809 - removal of org.jboss.jms.asf from the server project > >>>> > >>>> With those changes the server boots. > >>>> This has been committed. > >>>> > >>>> If you've nearly done the rest, I'll leave them to you, > >>>> otherwise let me know. > >>>> > >>>> On Thu, 2007-10-04 at 17:20 +0300, Dimitris Andreadis wrote: > >>>>> Ok, I'm nearly there (locally) with an overall rollback of the 17 commits, but won't commit > >>>>> anything. > >>>>> > >>>>> If you somehow get stuck, give me the green light :) > >> _______________________________________________ > >> jboss-development mailing list > >> jboss-development(a)lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development

Also, the embedded project is broken since it hasn't yet been updated to use the new TM.

I think you're correct, there's lots of little commits. :-( After reverting the transaction module change, I've now got problems with the MDB's ServerSessionPool. Caused by: java.lang.ClassNotFoundException : No ClassLoaders found for: org.jboss.jms.asf.ServerSessionPoolLoader at org.jboss.mx.loading.LoadMgr3.beginLoadTask(LoadMgr3.java:306) at org.jboss.mx.loading.UnifiedClassLoader.loadClassImpl ( UnifiedClassLoader.java:290) An alternative strategy would be try to complete Francisco's change by fixing the main configuration of the server. But this will leave lots of broken tests in the testsuite until they are also updated with the correct configuration. e.g. MDB tests with specific JMSContainerInvoker configuration will fail until they are updated to use the JCA 1.5 inbound resource adapter config. e.g.2 There's still lots of tests using the now non-existant org.jboss.tm.TxManager on the client side. Also, the embedded project is broken since it hasn't yet been updated to use the new TM. On Thu, 2007-10-04 at 16:47 +0300, Dimitris Andreadis wrote: > Those are the revision numbers (first one was last): > > Should we revert one by one in reverse order? > > 65826, 65825, 65820, 65819, 65818, 65817, 65816, 65815, 65814, 65813, 65812, 65811, 65810, > 65809, 65808, 65807, 65806 > > Dimitris Andreadis wrote: > > I just noticed Franscisco's check-ins this morning. I think we need to > > revert the changes for now, but unfortunately the check-ins done were > > multiple. > > > > Adrian wrote: > >> Why has the transaction module been removed? > >> > >> The stuff required to make this work properly is still WIP: > >> http://jira.jboss.com/jira/browse/JBAS-4516 > >> > >> In fact, I'm currently working on fixing up the testsuite > >> to make this possible at all. > >> > >> The XIDFactory stuff is expected as per the subtask: > >> http://jira.jboss.com/jira/browse/JBAS-4517 > >> > >> On Thu, 2007-10-04 at 16:12 +0300, Dimitris Andreadis wrote: > >>> After the removal of the transaction module, booting the 'default' > >>> and 'all' configs complains initially for the missing > >>> org.jboss.tm.XidFactory, then about missing jbossts libs... > >>> > >>> _______________________________________________ > >>> jboss-development mailing list > >>> jboss-development(a)lists.jboss.org > >>> https://lists.jboss.org/mailman/listinfo/jboss-development > > _______________________________________________ > > jboss-development mailing list > > jboss-development(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development -- xxxxxxxxxxxxxxxxxxxxxxxxxxxx Adrian Brock Chief Scientist JBoss, a division of Red Hat xxxxxxxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

Why has the transaction module been removed?

http://jira.jboss.com/jira/browse/JBAS-4516 In fact, I'm currently working on fixing up the testsuite to make this possible at all. The XIDFactory stuff is expected as per the subtask: http://jira.jboss.com/jira/browse/JBAS-4517 On Thu, 2007-10-04 at 16:12 +0300, Dimitris Andreadis wrote: > After the removal of the transaction module, booting the 'default' and 'all' configs > complains initially for the missing org.jboss.tm.XidFactory, then about missing jbossts libs... > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development -- xxxxxxxxxxxxxxxxxxxxxxxxxxxx Adrian Brock Chief Scientist JBoss, a division of Red Hat xxxxxxxxxxxxxxxxxxxxxxxxxxxx

I was wondering what was the point of reverting right away, and almost posted about it earlier. Usually, good practices are to wait about one day for the developer to respond to know about his plans ;)