I suppose because it's hard for individual users to make a full local testsuite run before every commit. It takes 5-6 hours. I'd be happy if people would monitor subsequent hudson runs to see the effects of their commits. The AS5 testsuite is now more or less stable/predictable so it's easy to spot regression. Sacha Labourey wrote: > why aren't we able to catch those regression *before* we commit them > to SVN? > > On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >> Yes, it comes from metadata. The tests fail to deploy. Emanuel is >> going to look into it. >> >> Caused by: java.lang.IllegalArgumentException: Can't find interface >> null in >> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >> >> at >> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >> >> at >> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >> >> at >> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >> >> at >> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >> >> at >> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >> >> at >> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >> >> >> >> Dimitris Andreadis wrote: >>> I suspect this huge regression (+1162 failures) is related to the >>> recent jboss-metadata update: >>> >>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... >>> >>> >> _______________________________________________ >> jboss-development mailing list >> jboss-development(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-development

Dimitris, roll back to the last beta version of MetaData (Beta16). Sacha Labourey wrote: > OK, I see. Still, here, we are speaking about +1162 failures, that > should be easy to detect just by starting any AS+app, no? ;) > > On 06/04/2008 02:15 PM, Dimitris Andreadis wrote: >> I suppose because it's hard for individual users to make a full local >> testsuite run before every commit. It takes 5-6 hours. >> >> I'd be happy if people would monitor subsequent hudson runs to see >> the effects of their commits. >> >> The AS5 testsuite is now more or less stable/predictable so it's easy >> to spot regression. >> >> Sacha Labourey wrote: >>> why aren't we able to catch those regression *before* we commit them >>> to SVN? >>> >>> On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >>>> Yes, it comes from metadata. The tests fail to deploy. Emanuel is >>>> going to look into it. >>>> >>>> Caused by: java.lang.IllegalArgumentException: Can't find interface >>>> null in >>>> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >>>> >>>> at >>>> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >>>> >>>> at >>>> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >>>> >>>> at >>>> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >>>> >>>> >>>> >>>> Dimitris Andreadis wrote: >>>>> I suspect this huge regression (+1162 failures) is related to the >>>>> recent jboss-metadata update: >>>>> >>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

No, it will just mitigate the panic attack you had today. In the metadata project, I see two test failues: ---------------------------------- Results : Failed tests: testSimpleProperties(org.jboss.test.metadata.ejb.JBossSessionBeanOverrideUnitTestCase) testSimpleProperties(org.jboss.test.metadata.ejb.JBossMessageDrivenBeanOverrideUnitTestCase) Tests run: 208, Failures: 2, Errors: 0, Skipped: 0 ------------------------------------ Dimitris Andreadis wrote: > Sure, rolling back commits is my favorite pastime, those days. > > Anil Saldhana wrote: >> Dimitris, roll back to the last beta version of MetaData (Beta16). >> >> Sacha Labourey wrote: >>> OK, I see. Still, here, we are speaking about +1162 failures, that >>> should be easy to detect just by starting any AS+app, no? ;) >>> >>> On 06/04/2008 02:15 PM, Dimitris Andreadis wrote: >>>> I suppose because it's hard for individual users to make a full >>>> local testsuite run before every commit. It takes 5-6 hours. >>>> >>>> I'd be happy if people would monitor subsequent hudson runs to see >>>> the effects of their commits. >>>> >>>> The AS5 testsuite is now more or less stable/predictable so it's >>>> easy to spot regression. >>>> >>>> Sacha Labourey wrote: >>>>> why aren't we able to catch those regression *before* we commit >>>>> them to SVN? >>>>> >>>>> On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >>>>>> Yes, it comes from metadata. The tests fail to deploy. Emanuel is >>>>>> going to look into it. >>>>>> >>>>>> Caused by: java.lang.IllegalArgumentException: Can't find >>>>>> interface null in >>>>>> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >>>>>> >>>>>> at >>>>>> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >>>>>> >>>>>> at >>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >>>>>> >>>>>> at >>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >>>>>> >>>>>> at >>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >>>>>> >>>>>> at >>>>>> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >>>>>> >>>>>> at >>>>>> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >>>>>> >>>>>> >>>>>> >>>>>> Dimitris Andreadis wrote: >>>>>>> I suspect this huge regression (+1162 failures) is related to >>>>>>> the recent jboss-metadata update: >>>>>>> >>>>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

even "funnier". It actually mean that the project has been released to the AS-trunk while its OWN testsuite wasn't passing? On 06/04/2008 02:39 PM, Anil Saldhana wrote: > No, it will just mitigate the panic attack you had today. > > In the metadata project, I see two test failues: > ---------------------------------- > Results : > > Failed tests: > > testSimpleProperties(org.jboss.test.metadata.ejb.JBossSessionBeanOverrideUnitTestCase) > > > testSimpleProperties(org.jboss.test.metadata.ejb.JBossMessageDrivenBeanOverrideUnitTestCase) > > > Tests run: 208, Failures: 2, Errors: 0, Skipped: 0 > ------------------------------------ > > > > Dimitris Andreadis wrote: >> Sure, rolling back commits is my favorite pastime, those days. >> >> Anil Saldhana wrote: >>> Dimitris, roll back to the last beta version of MetaData (Beta16). >>> >>> Sacha Labourey wrote: >>>> OK, I see. Still, here, we are speaking about +1162 failures, that >>>> should be easy to detect just by starting any AS+app, no? ;) >>>> >>>> On 06/04/2008 02:15 PM, Dimitris Andreadis wrote: >>>>> I suppose because it's hard for individual users to make a full >>>>> local testsuite run before every commit. It takes 5-6 hours. >>>>> >>>>> I'd be happy if people would monitor subsequent hudson runs to see >>>>> the effects of their commits. >>>>> >>>>> The AS5 testsuite is now more or less stable/predictable so it's >>>>> easy to spot regression. >>>>> >>>>> Sacha Labourey wrote: >>>>>> why aren't we able to catch those regression *before* we commit >>>>>> them to SVN? >>>>>> >>>>>> On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >>>>>>> Yes, it comes from metadata. The tests fail to deploy. Emanuel >>>>>>> is going to look into it. >>>>>>> >>>>>>> Caused by: java.lang.IllegalArgumentException: Can't find >>>>>>> interface null in >>>>>>> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >>>>>>> >>>>>>> at >>>>>>> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >>>>>>> >>>>>>> at >>>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >>>>>>> >>>>>>> at >>>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >>>>>>> >>>>>>> at >>>>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >>>>>>> >>>>>>> at >>>>>>> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >>>>>>> >>>>>>> at >>>>>>> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >>>>>>> >>>>>>> >>>>>>> >>>>>>> Dimitris Andreadis wrote: >>>>>>>> I suspect this huge regression (+1162 failures) is related to >>>>>>>> the recent jboss-metadata update: >>>>>>>> >>>>>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... > > > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

Yes, I fixed the regression with the merging of session beans, but these two tests were new functionality, so I ignored them. We are missing tests for whatever regression has shown up though, so have Emanuel introduce a unit test for whatever is failing in jbossas trunk please. Alexey Loubyansky wrote: > That's right. And that's right. > > They are not regressions. > _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

I tested locally Emanuel's latest jboss-metadata 1.0.0.Beta8 (thanks1), using Adrian's new smoke test (thanks2) and I'm getting only 3 failures. Before that most tests would fail: [junit] Running org.jboss.test.ejb3.test.SimpleSessionUnitTestCase [junit] Tests run: 1, Failures: 0, Errors: 2, Time elapsed: 0.188 sec [junit] Test org.jboss.test.ejb3.test.SimpleSessionUnitTestCase FAILED ... [junit] Tests run: 10, Failures: 0, Errors: 1, Time elapsed: 9.11 sec [junit] Test org.jboss.test.naming.test.SimpleUnitTestCase FAILED ... [junit] Running org.jboss.test.web.test.WebIntegrationUnitTestCase [junit] Tests run: 37, Failures: 1, Errors: 1, Time elapsed: 24.203 sec [junit] Test org.jboss.test.web.test.WebIntegrationUnitTestCase FAILED I've switched trunk to this latest metadata release to see what gives. While there, the JIRA project of jboss metadata could use some housekeeping: http://jira.jboss.com/jira/browse/JBMETA - The issues that appear resolved for CR1 should really be assigned to Betas that are already out - I've made a new Beta8 release that would supposedly need to include JBMETA-42 then marked as released The right approach when creating a new release would be to rename CR1 to that release and introduce a new CR1.

True, you could run some basic smoke tests first. Sacha Labourey wrote: > OK, I see. Still, here, we are speaking about +1162 failures, that > should be easy to detect just by starting any AS+app, no? ;) > > On 06/04/2008 02:15 PM, Dimitris Andreadis wrote: >> I suppose because it's hard for individual users to make a full local >> testsuite run before every commit. It takes 5-6 hours. >> >> I'd be happy if people would monitor subsequent hudson runs to see the >> effects of their commits. >> >> The AS5 testsuite is now more or less stable/predictable so it's easy >> to spot regression. >> >> Sacha Labourey wrote: >>> why aren't we able to catch those regression *before* we commit them >>> to SVN? >>> >>> On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >>>> Yes, it comes from metadata. The tests fail to deploy. Emanuel is >>>> going to look into it. >>>> >>>> Caused by: java.lang.IllegalArgumentException: Can't find interface >>>> null in >>>> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >>>> >>>> at >>>> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >>>> >>>> at >>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >>>> >>>> at >>>> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >>>> >>>> at >>>> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >>>> >>>> >>>> >>>> Dimitris Andreadis wrote: >>>>> I suspect this huge regression (+1162 failures) is related to the >>>>> recent jboss-metadata update: >>>>> >>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... >>>>> >>>>> >>>> _______________________________________________ >>>> jboss-development mailing list >>>> jboss-development(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jboss-development _______________________________________________ jboss-development mailing list jboss-development(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-development

I've made a start on this "feature" since we've talking about it for some time and nobody has done anything. ;-) See: http://jira.jboss.com/jira/browse/JBAS-5582 This could obviously do we some refining and probably some of the existing tests splitting up to extra the basic standup tests from the other more complicated ones. I basically took the tests that I normally use as "standup tests" when I do major changes. It's hard to tell how long this will take, but with the currently broken state it took less than 5 minutes (including starting and stopping the server) so there can't be any real complaints about not running this on all major commits. ;-) On Wed, 2008-06-04 at 15:22 +0300, Dimitris Andreadis wrote: > True, you could run some basic smoke tests first. > > Sacha Labourey wrote: >> OK, I see. Still, here, we are speaking about +1162 failures, that >> should be easy to detect just by starting any AS+app, no? ;) >> >> On 06/04/2008 02:15 PM, Dimitris Andreadis wrote: >>> I suppose because it's hard for individual users to make a full local >>> testsuite run before every commit. It takes 5-6 hours. >>> >>> I'd be happy if people would monitor subsequent hudson runs to see the >>> effects of their commits. >>> >>> The AS5 testsuite is now more or less stable/predictable so it's easy >>> to spot regression. >>> >>> Sacha Labourey wrote: >>>> why aren't we able to catch those regression *before* we commit them >>>> to SVN? >>>> >>>> On 06/04/2008 12:50 PM, Alexey Loubyansky wrote: >>>>> Yes, it comes from metadata. The tests fail to deploy. Emanuel is >>>>> going to look into it. >>>>> >>>>> Caused by: java.lang.IllegalArgumentException: Can't find interface >>>>> null in >>>>> org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData@af9ed402{AuditSessionEJB} >>>>> >>>>> at >>>>> org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData.determineResolvedJndiName(JBossEnterpriseBeanMetaData.java:702) >>>>> >>>>> at >>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEjbs(MappedReferenceMetaDataResolverDeployer.java:332) >>>>> >>>>> at >>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.mapEndpoints(MappedReferenceMetaDataResolverDeployer.java:219) >>>>> >>>>> at >>>>> org.jboss.deployment.MappedReferenceMetaDataResolverDeployer.internalDeploy(MappedReferenceMetaDataResolverDeployer.java:140) >>>>> >>>>> at >>>>> org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) >>>>> >>>>> at >>>>> org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:174) >>>>> >>>>> >>>>> >>>>> Dimitris Andreadis wrote: >>>>>> I suspect this huge regression (+1162 failures) is related to the >>>>>> recent jboss-metadata update: >>>>>> >>>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... >>>>>> >>>>>> >>>>> _______________________________________________ >>>>> jboss-development mailing list >>>>> jboss-development(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/jboss-development > _______________________________________________ > jboss-development mailing list > jboss-development(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-development