Request for review (Configuration Admin Changes for AS7-4893)
by David Bosschaert
Before filing a pull request I would appreciate someone reviewing my
suggested changes for
https://issues.jboss.org/browse/AS7-4893 (ConfigAdmin configuration not
available after restart)
My changes are in the following commit:
https://github.com/bosschaert/jboss-as/commit/bf221bc316c254401ee1b1c25d9...
In particular I'm a little unsure about the
ConfigurationRemove.UPDATING_FLAG that I introduced.
ConfigurationAdminServiceImpl.putConfiguration() first removes the old
configuration from the model and then adds the new one. The problem is
that the deletion in this case shouldn't really be sent to the
ConfigurationAdmin service as we aren't really deleting the config
object. The UPDATING_FLAG is used to indicate that notifications should
not be sent of this removal. I guess the mismatch is that OSGi
ConfigAdmin has an update() which replaces the old value where the DMR
API only supports REMOVE followed by ADD.
Maybe I should get rid of this UPDATING_FLAG and an UPDATE operation to
the DMR API? Any ideas appreciated
Cheers,
David
14 years
Re: [jboss-osgi-dev] Test failures in Repository CT
by Thomas Diesler
Hi David,
I'd like to turn this process around. If you see a failure in
jbosgi-repository please describe the issue in the context of that
project. The functional scope should be defined in the jbosgi-repository
testsuite and not in some external testsuite that is not publicly
accessible. The best approach is probably to create a pull request with
failing tests against jbosgi/jbosgi-repository.
cheers
-thomas
On 05/25/2012 09:09 AM, David Bosschaert wrote:
> Hi Thomas,
>
> I've written a few tests for the Repo CT most of which fail at the
> moment. You can find them on my davidb/repo_ct branch in OSGi git here:
> https://www.osgi.org/members/gitweb/build.git/blob/davidb/repo_ct:/org.os...
>
>
> The two tests that are passing are testQueryByBundleID() and
> testDisconnectedQueries(). The other tests fail.
> It should be fairly clear what the tests are doing, I'm also attaching
> a test report FYI to show what fails.
>
> If you want to run it, you need to copy the following into the OSGi
> build:
> licensed/repo/org.jboss.logging.jboss-logging/
> licensed/repo/org.jboss.repository.jbosgi-repository-tck/
> licensed/repo/org.jboss.repository.jbosgi-repository/
> The jbosgi-repository-tck is a bundle that currently exists here:
> https://github.com/bosschaert/jbosgi-repository/tree/tckbundle/tck
>
> The test suite is not yet complete, but this is a start to work through.
>
> Cheers,
>
> David
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years
Re: [jboss-osgi-dev] Maven settings.xml issue
by Thomas Diesler
Thanks for clarifying this.
On 05/23/2012 03:43 PM, Paul Gier wrote:
> On 05/23/2012 07:52 AM, Thomas Diesler wrote:
>> Hi Paul,
>>
>> while trying to reproduce https://issues.jboss.org/browse/ARQ-520 I
>> notice that I cannot run my testsuite because of
>>
>> [INFO] Building JBossOSGi Repository: Integration Tests
>> 1.3.0.Beta5-SNAPSHOT
>> [INFO]
>> ------------------------------------------------------------------------
>> Downloading:
>> http://repo1.maven.org/maven2/org/jboss/osgi/jboss-osgi-parent/1.0.18/jbo...
>>
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] JBossOSGi Repository .............................. SUCCESS [0.680s]
>> [INFO] JBossOSGi Repository: API ......................... SUCCESS [6.656s]
>> [INFO] JBossOSGi Repository: Core ........................ SUCCESS [3.275s]
>> [INFO] JBossOSGi Repository: Bundle ...................... SUCCESS [3.194s]
>> [INFO] JBossOSGi Repository: Integration Tests ........... FAILURE [0.501s]
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Total time: 15.927s
>> [INFO] Finished at: Wed May 23 14:41:52 CEST 2012
>> [INFO] Final Memory: 26M/196M
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] Failed to execute goal on project jbosgi-repository-itests:
>> Could not resolve dependencies for project
>> org.jboss.osgi.repository:jbosgi-repository-itests:jar:1.3.0.Beta5-SNAPSHOT:
>> Failed to collect dependencies for
>> [org.jboss.osgi.repository:jbosgi-repository-api:jar:1.3.0.Beta5-SNAPSHOT (provided),
>> org.jboss.osgi.repository:jbosgi-repository:jar:1.3.0.Beta5-SNAPSHOT
>> (provided),
>> org.jboss.arquillian.container:arquillian-container-osgi-embedded:jar:1.0.3-SNAPSHOT
>> (test),
>> org.jboss.arquillian.junit:arquillian-junit-container:jar:1.0.0.Final
>> (test), org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4 (test),
>> org.jboss.logmanager:jboss-logmanager:jar:1.2.2.GA (test),
>> org.jboss.osgi.framework:jbosgi-framework-core:jar:1.4.0.CR1
>> (provided)]: Failed to read artifact descriptor for
>> org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4: Could not transfer
>> artifact org.jboss.osgi:jboss-osgi-parent:pom:1.0.18 from/to central
>> (http://repo1.maven.org/maven2): Error transferring file:
>> repo1.maven.org: Unknown host repo1.maven.org -> [Help 1]
>>
>> The artefact in question is however available locally. When I define the
>> jboss nexus repositories either in settings.xml or in the project it
>> works fine (also without network connection). Do you know what's going on?
>>
> The "Unknown host repo1.maven.org" seems strange, are you able to ping
> the server and browse artifacts?
>
> Maven keeps some metadata that records which repositories each artifact
> comes from. So if the metadata says that jboss-osgi-parent came from
> the jboss Nexus repository, then it won't use the local artifact
> automatically unless it's also available in one of the currently active
> repositories.
>
>> I also don't quite understand the reasoning about not defining the repos
>> in the project. How can my project repos leak into other projects if my
>> project's pom is not the parent?
>>
> Maven will (unfortunately) add repositories to the build if it finds any
> repositories in dependency poms. So a build that depends on an osgi jar
> will add the jboss.org repo to it's own build if the the osgi pom has
> the jboss.org defined.
>
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years
Maven settings.xml issue
by Thomas Diesler
Hi Paul,
while trying to reproduce https://issues.jboss.org/browse/ARQ-520 I
notice that I cannot run my testsuite because of
[INFO] Building JBossOSGi Repository: Integration Tests 1.3.0.Beta5-SNAPSHOT
[INFO]
------------------------------------------------------------------------
Downloading:
http://repo1.maven.org/maven2/org/jboss/osgi/jboss-osgi-parent/1.0.18/jbo...
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] JBossOSGi Repository .............................. SUCCESS [0.680s]
[INFO] JBossOSGi Repository: API ......................... SUCCESS [6.656s]
[INFO] JBossOSGi Repository: Core ........................ SUCCESS [3.275s]
[INFO] JBossOSGi Repository: Bundle ...................... SUCCESS [3.194s]
[INFO] JBossOSGi Repository: Integration Tests ........... FAILURE [0.501s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 15.927s
[INFO] Finished at: Wed May 23 14:41:52 CEST 2012
[INFO] Final Memory: 26M/196M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal on project jbosgi-repository-itests:
Could not resolve dependencies for project
org.jboss.osgi.repository:jbosgi-repository-itests:jar:1.3.0.Beta5-SNAPSHOT:
Failed to collect dependencies for
[org.jboss.osgi.repository:jbosgi-repository-api:jar:1.3.0.Beta5-SNAPSHOT (provided),
org.jboss.osgi.repository:jbosgi-repository:jar:1.3.0.Beta5-SNAPSHOT
(provided),
org.jboss.arquillian.container:arquillian-container-osgi-embedded:jar:1.0.3-SNAPSHOT
(test),
org.jboss.arquillian.junit:arquillian-junit-container:jar:1.0.0.Final
(test), org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4 (test),
org.jboss.logmanager:jboss-logmanager:jar:1.2.2.GA (test),
org.jboss.osgi.framework:jbosgi-framework-core:jar:1.4.0.CR1
(provided)]: Failed to read artifact descriptor for
org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4: Could not transfer
artifact org.jboss.osgi:jboss-osgi-parent:pom:1.0.18 from/to central
(http://repo1.maven.org/maven2): Error transferring file:
repo1.maven.org: Unknown host repo1.maven.org -> [Help 1]
The artefact in question is however available locally. When I define the
jboss nexus repositories either in settings.xml or in the project it
works fine (also without network connection). Do you know what's going on?
I also don't quite understand the reasoning about not defining the repos
in the project. How can my project repos leak into other projects if my
project's pom is not the parent?
cheers
-thomas
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years
Maven settings.xml issue
by Thomas Diesler
Hi Paul,
while trying to reproduce https://issues.jboss.org/browse/ARQ-520 I
notice that I cannot run my testsuite because of
[INFO] Building JBossOSGi Repository: Integration Tests 1.3.0.Beta5-SNAPSHOT
[INFO]
------------------------------------------------------------------------
Downloading:
http://repo1.maven.org/maven2/org/jboss/osgi/jboss-osgi-parent/1.0.18/jbo...
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] JBossOSGi Repository .............................. SUCCESS [0.680s]
[INFO] JBossOSGi Repository: API ......................... SUCCESS [6.656s]
[INFO] JBossOSGi Repository: Core ........................ SUCCESS [3.275s]
[INFO] JBossOSGi Repository: Bundle ...................... SUCCESS [3.194s]
[INFO] JBossOSGi Repository: Integration Tests ........... FAILURE [0.501s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 15.927s
[INFO] Finished at: Wed May 23 14:41:52 CEST 2012
[INFO] Final Memory: 26M/196M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal on project jbosgi-repository-itests:
Could not resolve dependencies for project
org.jboss.osgi.repository:jbosgi-repository-itests:jar:1.3.0.Beta5-SNAPSHOT:
Failed to collect dependencies for
[org.jboss.osgi.repository:jbosgi-repository-api:jar:1.3.0.Beta5-SNAPSHOT (provided),
org.jboss.osgi.repository:jbosgi-repository:jar:1.3.0.Beta5-SNAPSHOT
(provided),
org.jboss.arquillian.container:arquillian-container-osgi-embedded:jar:1.0.3-SNAPSHOT
(test),
org.jboss.arquillian.junit:arquillian-junit-container:jar:1.0.0.Final
(test), org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4 (test),
org.jboss.logmanager:jboss-logmanager:jar:1.2.2.GA (test),
org.jboss.osgi.framework:jbosgi-framework-core:jar:1.4.0.CR1
(provided)]: Failed to read artifact descriptor for
org.jboss.osgi.testing:jbosgi-testing:jar:1.0.4: Could not transfer
artifact org.jboss.osgi:jboss-osgi-parent:pom:1.0.18 from/to central
(http://repo1.maven.org/maven2): Error transferring file:
repo1.maven.org: Unknown host repo1.maven.org -> [Help 1]
The artefact in question is however available locally. When I define the
jboss nexus repositories either in settings.xml or in the project it
works fine (also without network connection). Do you know what's going on?
I also don't quite understand the reasoning about not defining the repos
in the project. How can my project repos leak into other projects if my
project's pom is not the parent?
cheers
-thomas
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years
Deploying the JBOSGi Repository
by David Bosschaert
Hi Thomas,
In preparation for being able to run the JBOSGi repository in the OSGi
TCK I need to be able to deploy it outside of the JBoss OSGi framework -
the TCK uses Equinox.
When I was trying this there were a number of dependencies that I could
not find OSGi bundles for:
org.jboss.osgi.metadata;version="[2.0,3.0)"
org.jboss.osgi.resolver;version="[2.0,3.0)"
org.jboss.osgi.resolver.spi;version="[2.0,3.0)"
Are these available as OSGi bundles somewhere?
Thanks,
David
14 years
Re: [jboss-osgi-dev] Hot deployment folder
by Thomas Diesler
Yes I gave this more thought and came to the conclusion that we should
not have an inconsistent hack like this. I know it s not an easy
decision and we must also consider future EAP versions and the principal
of least surprise. Please open a forum discussion were we can discuss
this ans come to a conclusion and possible action plan for 7.1.3.
Currently, a user will have to start the bundle explicitly through cli,
console or felix webconsole. AFIAC this is an area of insufficient
support from underlying AS7, which might bring the felix webconsole back
into the jbosgi-1.2.0 distro. We can also talk about this in todays call
if you like.
cheers
-thomas
On 05/14/2012 09:33 AM, David Bosschaert wrote:
> Hi Thomas,
>
> While looking at OSGi in AS7.1.2 I noticed that the 'autostart when
> dropped in hotdeployment folder' as we talked about in Paris isn't
> implemented. I guess it's not too much of a big deal, but what do you
> consider to be the simplest way for a user to deploy and start a bundle?
>
> David
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years
Re: [jboss-osgi-dev] License Maven Plugin
by Thomas Diesler
Thanks Paul,
the google plugin seems to support removing of existing headers.
-thomas
On 05/11/2012 03:30 PM, Paul Gier wrote:
> The only part of that plugin that I really use is the download-licenses
> goal. Does the update-file-header-goal do what you want? If the
> codehaus plugin doesn't work for you, you could also try the google one.
>
> http://code.google.com/p/maven-license-plugin/
>
> On 05/11/2012 01:31 AM, Thomas Diesler wrote:
>> Hi Paul,
>>
>> I'm using the codehaus license
>> <http://mojo.codehaus.org/license-maven-plugin/team-list.html> plugin to
>> re-license one of my projects. Do you know if there is a way to strip
>> the old file headers?
>>
>> cheers
>> -thomas
>>
>> --
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
14 years