I actually have some more tests now but some of these (partly) fail
because of the issues exposed in
https://github.com/jbosgi/jbosgi-repository/pull/2 so I'll wait with
submitting those until this pull request is handled...
On 19/06/2012 15:36, David Bosschaert wrote:
> Hi Thomas,
> I just filed another pull request that exposes the 2 additional
> failures that I'm getting.
Before filing a pull request I would appreciate someone reviewing my
suggested changes for
https://issues.jboss.org/browse/AS7-4893 (ConfigAdmin configuration not
available after restart)
My changes are in the following commit:
In particular I'm a little unsure about the
ConfigurationRemove.UPDATING_FLAG that I introduced.
ConfigurationAdminServiceImpl.putConfiguration() first removes the old
configuration from the model and then adds the new one. The problem is
that the deletion in this case shouldn't really be sent to the
ConfigurationAdmin service as we aren't really deleting the config
object. The UPDATING_FLAG is used to indicate that notifications should
not be sent of this removal. I guess the mismatch is that OSGi
ConfigAdmin has an update() which replaces the old value where the DMR
API only supports REMOVE followed by ADD.
Maybe I should get rid of this UPDATING_FLAG and an UPDATE operation to
the DMR API? Any ideas appreciated