I haven't really touched the MetaData that Ales (and I think from the comments Scott)
worked on. This is what I would describe as what needs doing.
MANIFEST vs PROPER OBJECT MODEL
I don't really like the idea that this is basically stored in a Manifest with a
wrapper.
That might be nice for real OSGi deployments but it makes it difficult if you want to:
* add osgi metadata by hand
* modify osgi metadata - e.g. in the profile service/console
* expose other metadata as though it was osgi metadata, e.g. so non-osgi classloading
rules can be exposed using the OSGi management queries.
BUILDER
The previous comment might be mitigated if there was some kind of
OSGiMetaDataBuilder class to make it easier?
OBJECT CONSTRUCTION
The metadata seems to have a whole copy of what is done by TypeInfo.convertValue()
it should just use that.
LOCALISATION
I'm not entirely sure how this is supposed to work? But I've put a TODO
where I think it should done. :-)
VERSION RANGE
I've reworked this so that it uses the ClassLoading VersionRange.
The only thing I can see that is different is that the the OSGi class
has a static method to parse the range from a string?
COMPLETION/TESTING
I've not looked too deeply at all the metadata. But there are obviously some things
missing as well as some things being wrong, e.g. exporting packages gives
you a version range instead of a version?
View the original post :
http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4249962#...
Reply to the post :
http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...